Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WITH_ITK in CI #1615

Merged
merged 14 commits into from
Oct 22, 2021
Merged

Add WITH_ITK in CI #1615

merged 14 commits into from
Oct 22, 2021

Conversation

kerautret
Copy link
Member

@kerautret kerautret commented Oct 15, 2021

PR Description

Activate WITH_ITK options in GitHub Actions and fix an ITK 4 versus 5.0 function call.
It works in linux distribution but a #include<cmath.h> makes some strange errors, after numerous tries I am giving up.. Perhaps trying again later after update of Xcode.

Checklist

  • Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug mode.
  • All continuous integration tests pass (Github Actions & appveyor)

@kerautret kerautret changed the title add WITH_ITK WIP add WITH_ITK in CI Oct 15, 2021
@kerautret kerautret changed the title WIP add WITH_ITK in CI Add WITH_ITK in CI Oct 17, 2021
Copy link
Member

@phcerdan phcerdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. The latest major version of ITK is 5, and here you are using libinsighttoolkit4-dev but I don't expect it changes much.

@kerautret
Copy link
Member Author

Thanks, yes it was more easy to use the version 4 since I do not see any package yet (and it could be quite long to include from sources in CI)

Copy link
Member

@dcoeurjo dcoeurjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@dcoeurjo dcoeurjo merged commit 40f4269 into DGtal-team:master Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants