-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display improvement for 2D cell in basic mode. #783
Display improvement for 2D cell in basic mode. #783
Conversation
@@ -1,6 +1,8 @@ | |||
=== DGtal 0.8 === | |||
|
|||
|
|||
*IO Package* | |||
- Basic mode to display surfel (Cell oriented or not) improved with a simple face display. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you think of:
" - New 'basic' display mode for surfels (oriented or not), useful for large digital surface displays (quads instead of 3D prisms) "
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes thank,
I don't understand why you had to update the "Viewer3D.ih". Have you fixed another issue in the same PR ? Could these edits be also considered in Board3D or Board3DTo2D ? Although, great and very useful mode;) |
The problem is that we need to have a double sided surfel display (since by itself the surfel doesn't contain inside/ouside information) which implies an edit in Viewer3D with specific openGL setting for this list. |
new version with all basic sufels in the main "myQuadSetList" (no pb of double sided with default double lightning option of Viewer3D it is ok). |
travis is failing, could you please have a look ? |
Ho yes sorry for the delay I look it ;( |
@dcoeurjo Travis should be fixed now... (sorry for the delay)... |
thanks merging |
Display improvement for 2D cell in basic mode.
Small PR which will improve the display (faster and better quality) when only need to display simple surfers (for instance to display curvature on boundary).
Now when using:
viewer << DGtal::SetMode3D(surfel.className(), "Basic");
It will only display surfel ( signed (or not) Cell of dim 2) as a quad in a new list to allow to display front and back side.