Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph2vol #76

Merged
merged 12 commits into from Feb 2, 2024
Merged

Graph2vol #76

merged 12 commits into from Feb 2, 2024

Conversation

kerautret
Copy link
Member

PR Description

New tool to convert graph object into volumetric image.

Checklist

  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • Check if it follows the tools structure described in CONTRIBUTING.md
  • New entry in the ChangeLog.md added.
  • Update the readme with potentially a screenshot of the tools if it applies.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).
  • All continuous integration tests pass (Github Actions & appveyor).

Copy link
Member

@dcoeurjo dcoeurjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR again ;)


@code
-h,--help Print this help message and exit
-v,--inputVertex TEXT:FILE REQUIRED input file containing the vertex list.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the vertex list is a sequence of points in Z³ ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If so, it should be mentioned that the "embedding" of the vertices is explicitly given

@kerautret
Copy link
Member Author

Thanks @dcoeurjo that done and new option to add margin

@kerautret kerautret merged commit 79e7d43 into DGtal-team:master Feb 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants