Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matched data in a single dataframe #192

Merged
merged 12 commits into from
May 25, 2023
Merged

Matched data in a single dataframe #192

merged 12 commits into from
May 25, 2023

Conversation

ecomodeller
Copy link
Member

No description provided.

@ecomodeller ecomodeller marked this pull request as draft May 15, 2023 08:00
@ecomodeller ecomodeller marked this pull request as ready for review May 20, 2023 13:12
Copy link
Member

@jsmariegaard jsmariegaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great except for the extra dependency "scikit-learn" - I don't think we should add this as a dependency due to an example. Could you please modify the example slightly so it loads some ML data instead of training the model?

@ecomodeller
Copy link
Member Author

Looks great except for the extra dependency "scikit-learn" - I don't think we should add this as a dependency due to an example. Could you please modify the example slightly so it loads some ML data instead of training the model?

Sure, then it will simply be a notebook that reads some arbitrary data from a dataframe, ready to be compared.

@jsmariegaard
Copy link
Member

:shipit: ?

@ecomodeller ecomodeller merged commit 6863829 into main May 25, 2023
9 checks passed
@ecomodeller ecomodeller deleted the matched branch May 25, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants