Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

from_matched_data for track data #420

Merged
merged 5 commits into from
Feb 13, 2024
Merged

from_matched_data for track data #420

merged 5 commits into from
Feb 13, 2024

Conversation

ecomodeller
Copy link
Member

@daniel-caichac-DHI pointed out that it is very common to have matched track data extracted from model results with e.g. DataTrackExtractionFM.

This PR makes is easy to use such kind of matched data.

@ecomodeller ecomodeller marked this pull request as draft February 12, 2024 13:46
@ecomodeller ecomodeller marked this pull request as ready for review February 12, 2024 14:52
@@ -105,6 +107,10 @@ def from_matched(
y-coordinate of observation, by default None
z : float, optional
z-coordinate of observation, by default None
x_item: [str, int], optional,
Name of x item, only relevant for track data
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or index

Copy link
Member

@jsmariegaard jsmariegaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See minor comment "or index"

@ecomodeller ecomodeller merged commit 6977510 into main Feb 13, 2024
11 checks passed
@ecomodeller ecomodeller deleted the from_compared_track branch February 13, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants