Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare some more for NumPy 2.0 #439

Merged
merged 7 commits into from
Jun 19, 2024
Merged

Prepare some more for NumPy 2.0 #439

merged 7 commits into from
Jun 19, 2024

Conversation

ecomodeller
Copy link
Member

@ecomodeller ecomodeller commented Jun 6, 2024

Numpy 2 changed the repr of scalars
https://numpy.org/doc/stable/release/2.0.0-notes.html#representation-of-numpy-scalars-changed

>>> import numpy as np
>>> np.zeros(2).min()
np.float64(0.0)

@ecomodeller
Copy link
Member Author

Seems like it will take some time until it is possible to have all tests passing with NumPy 2.0😐 due to all the dependencies.

@jsmariegaard
Copy link
Member

Have you tried with ruff? See e.g. https://numpy.org/devdocs/numpy_2_0_migration_guide.html

$ ruff check path/to/code/ --select NPY201

@ecomodeller
Copy link
Member Author

Have you tried with ruff? See e.g. https://numpy.org/devdocs/numpy_2_0_migration_guide.html

$ ruff check path/to/code/ --select NPY201

Yes, nothing to fix.

@ecomodeller ecomodeller marked this pull request as ready for review June 18, 2024 10:08
@ecomodeller ecomodeller merged commit bf72102 into main Jun 19, 2024
9 checks passed
@ecomodeller ecomodeller deleted the numpy2 branch June 19, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants