Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v6r21][WIP]Add some tutorials #4026

Closed
wants to merge 11 commits into from

Conversation

chaen
Copy link
Contributor

@chaen chaen commented Apr 11, 2019

This PR will contain the necessary things for the DMS + TS tutorial.
@andresailer @fstagni @atsareg please take a peek

The first tutorial is the setup of an installation for basic server + client, with WebApp and local CA. It is very largely inspired by the existing guides, except that no choice is given to the user (as a tutorial should be).
You can see it here: https://chaen-dirac.readthedocs.io/en/rel-v6r21_tuto_tsdms/AdministratorGuide/Tutorials/basicTutoSetup.html

This installation should be the base for all future tutorials

More will come, do not merge yet please

BEGINRELEASENOTES

*Core
NEW: install_site supports DIRACOS

*Docs
NEW: basic server and client tutorial
NEW: DIRAC SE tutorial
NEW: DFC tutorial

ENDRELEASENOTES

@coveralls
Copy link

coveralls commented Apr 11, 2019

Coverage Status

Coverage increased (+0.008%) to 22.17% when pulling dd80252 on chaen:rel-v6r21_TUTO_TSDMS into a72e013 on DIRACGrid:rel-v6r21.

Client installation
===================

Now we will create another linux account `diracuser` and another installation to be used as client
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you mention that for simplicity this can be done on the same machine, but can also be done on a different one. It's pretty obvious, of course, but shows that this installation is fully capable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is a tutorial, I'd rather be in favour of NOT giving any choice nor option. Otherwise you risk having people diverging. I can mention it, but I am not sure that it brings anything

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to decide if what you are writing here is either:

  1. "the tutorial for the workshop", or
  2. "a general tutorial", that will also be used in the workshop to demonstrate something.

Of course you started with option 1, as this is the use case. My question is "can we make it a general one, so option 2"?

There are in the wiki some links to past tutorials/hands-on: https://github.com/DIRACGrid/DIRAC/wiki/DIRAC-Tutorials. There is also the one of last year's workshop. What we should aim to, in this "official documentation" is for general tutorials that readers can do alone. What you will do in the workshop can follow the lines outlined here, with maybe some deviations for convenience.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I am aiming at is option 2. And Tutorial at the DUW should just follow that. But to save time, this part would already be done for them

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just went through the wiki.
We duplicate so much the source of information :-)
How about just linkinf readthedocs from the wiki ?

@atsareg
Copy link
Contributor

atsareg commented Apr 15, 2019

I agree in general. We can keep some specific tutotials in the WiKi though, like a Quick one

@chaen
Copy link
Contributor Author

chaen commented Apr 15, 2019

Why ? This will for sure diverge :-( Oh btw, I did not know about this -V option of DIRAC install ! That's clever :-)

@fstagni
Copy link
Contributor

fstagni commented Apr 15, 2019

Wiki are for "unmonitored", often "temporary" and sometimes "unofficial" docs. I would say that, as a general rule, we should promote the readthedocs tutorial as the "always updated" ones. What's in wiki should refer to it.

@chaen
Copy link
Contributor Author

chaen commented Apr 16, 2019

I've added a tuto for installing a DIRAC SE and one for the DFC.

@codecov-io
Copy link

codecov-io commented Apr 16, 2019

Codecov Report

Merging #4026 into rel-v6r21 will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           rel-v6r21    #4026      +/-   ##
=============================================
- Coverage      22.05%   22.05%   -0.01%     
=============================================
  Files            906      906              
  Lines         128904   128904              
=============================================
- Hits           28435    28427       -8     
- Misses        100469   100477       +8
Impacted Files Coverage Δ
Core/Utilities/LockRing.py 62.02% <0%> (-2.54%) ⬇️
Core/Utilities/ProcessPool.py 81.94% <0%> (-1.08%) ⬇️
Core/Utilities/test/Test_ProcessPool.py 85.78% <0%> (-0.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8727f53...2b8df33. Read the comment docs.

docs/source/AdministratorGuide/Tutorials/index.rst Outdated Show resolved Hide resolved
docs/source/AdministratorGuide/Tutorials/index.rst Outdated Show resolved Hide resolved

This section has to be ran as `diracuser`

We will do the installation in the `~/DIRAC` directory. For a client, the configuration is really minimal, so we will just install the code and its dependencies.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the ~/DIRAC directory is IMHO a bad name. It will then have another DIRAC directory inside it. Call it differently.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you propose ? DiracInstallation ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's possible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I'll change to that

Copy link
Contributor

@andresailer andresailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just very picky comments: use double ticks instead of single ticks for emphasis, single ticks will be interpreted by sphinx as links to something else (it tries at least), and if one enables picky mode there would be a lot of warnings.
Bullet lists do not need to be indented
Some typos, proposals to change words

The aim of the tutorial is to have a self contained DIRAC setup. You will be guided through the whole installation process both of the server part and the client part.
By the end of the tutorial, you will have:

* a Configuration service, to server other servers and clients
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* a Configuration service, to server other servers and clients
* a Configuration service, to serve other servers and clients

By the end of the tutorial, you will have:

* a Configuration service, to server other servers and clients
* a ComponentMonitoring service to keep track of other services and agents installed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* a ComponentMonitoring service to keep track of other services and agents installed
* a ComponentMonitoring service to keep track of other services and agents installed


* a Configuration service, to server other servers and clients
* a ComponentMonitoring service to keep track of other services and agents installed
* a SystemAdministrator service to manage the DIRAC installation in the future
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* a SystemAdministrator service to manage the DIRAC installation in the future
* a SystemAdministrator service to manage the DIRAC installation in the future

* a Configuration service, to server other servers and clients
* a ComponentMonitoring service to keep track of other services and agents installed
* a SystemAdministrator service to manage the DIRAC installation in the future
* the WebApp, to allow for web interface access
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* the WebApp, to allow for web interface access
* the WebApp, to allow for web interface access


You should:

* have a machine setup as described in :ref:`tuto_basic_setup`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* have a machine setup as described in :ref:`tuto_basic_setup`
* have a machine setup as described in :ref:`tuto_basic_setup`

You should:

* have a machine setup as described in :ref:`tuto_basic_setup`
* be able to install dirac components
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* be able to install dirac components
* be able to install dirac components


* have a machine setup as described in :ref:`tuto_basic_setup`
* be able to install dirac components
* have installed a DIRAC SE using the tutorial (:ref:`tuto_install_dirac_se`).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* have installed a DIRAC SE using the tutorial (:ref:`tuto_install_dirac_se`).
* have installed a DIRAC SE using the tutorial (:ref:`tuto_install_dirac_se`).


echo "dummyFile" > /tmp/dummy.txt

Now create a file called `/tmp/testSE.py`, with the following content::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Now create a file called `/tmp/testSE.py`, with the following content::
Now create a file called ``/tmp/testSE.py``, with the following content::




This file uploads `/tmp/dummy.txt` on the StorageElement, list the directory and removes it. The output should be something like that::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This file uploads `/tmp/dummy.txt` on the StorageElement, list the directory and removes it. The output should be something like that::
This file uploads ``/tmp/dummy.txt`` on the StorageElement, list the directory and removes it. The output should be something like that::

@chaen
Copy link
Contributor Author

chaen commented Apr 23, 2019

Thanks a lot.
Regarding the lists, is it a problem to keep them indented ? I find it much nicer when writing the doc. If it creates a warning, then no problem, I will remove the indentation

@andresailer
Copy link
Contributor

It doesn't create a warning, but it affects the way the result is rendered, the more indentation in the rst the more indentation in the html, so things are not looking consistent

@chaen
Copy link
Contributor Author

chaen commented Apr 23, 2019

Fine, then I'll remove the indenation

@chaen
Copy link
Contributor Author

chaen commented Apr 24, 2019

I'll close that one and re-open one cleaner

@chaen chaen closed this Apr 24, 2019
@chaen chaen deleted the rel-v6r21_TUTO_TSDMS branch August 11, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants