[8.1] Resolve methods of the REST interface #6873
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaen
reviewed
Mar 1, 2023
| prefix = prefix.lower() | ||
| for mName, mObj in inspect.getmembers(cls, lambda x: callable(x) and x.__name__.startswith(prefix)): | ||
| methodName = mName[len(prefix) :] | ||
| for mName in cls.__dict__: |
There was a problem hiding this comment.
If I understand properly, the only real difference between these two implementations is that you are looping over __dict__ instead of inspect.getmembers, is that correct ?
The logic otherwise seems the same ?
There was a problem hiding this comment.
Yes, the logic does not change, just extra unnecessary stuff does not get exposed
There was a problem hiding this comment.
We already rejected the use of __dict__: #6128
There was a problem hiding this comment.
yes but then the parent class is not exposed, so the extensions are broken
edit: oops, hadn't refreshed, so did not see @chrisburr comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR avoids exposing methods from parent classes of the REST handler implementation class.
BEGINRELEASENOTES
*Core
FIX: TornadoREST - resolve interface method names for standard HTTP access methods
ENDRELEASENOTES