Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SysEx events causing an infinite loop #16

Closed
wants to merge 1 commit into from

Conversation

PolyCement
Copy link

I investigated the cause of #9 after running into the same issue myself and found that it enters an infinite loop when handling events bigger than 4 bytes, such as the 12 byte SysEx events my midi controller emits whenever I hit the octave up/down buttons.

I don't have much experience in writing audio plugins so I'm not sure what these 2 lines were intended to do, but since the event size doesn't change, if it's greater than 4 it just keeps looping forever. nekobee_handle_raw_event returns without doing anything if the event isn't exactly 3 bytes, so removing that if statement causes the event to be skipped and fixes the issue.

@falkTX
Copy link
Contributor

falkTX commented Oct 30, 2022

That was a good catch, I did a simplified version in 0e999f3

@falkTX falkTX closed this Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants