Fix SysEx events causing an infinite loop #16
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I investigated the cause of #9 after running into the same issue myself and found that it enters an infinite loop when handling events bigger than 4 bytes, such as the 12 byte SysEx events my midi controller emits whenever I hit the octave up/down buttons.
I don't have much experience in writing audio plugins so I'm not sure what these 2 lines were intended to do, but since the event size doesn't change, if it's greater than 4 it just keeps looping forever.
nekobee_handle_raw_event
returns without doing anything if the event isn't exactly 3 bytes, so removing that if statement causes the event to be skipped and fixes the issue.