Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frequency of toast notification in joystick onMove() method #119

Open
livmari opened this issue May 20, 2020 · 2 comments
Open

Frequency of toast notification in joystick onMove() method #119

livmari opened this issue May 20, 2020 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@livmari
Copy link
Contributor

livmari commented May 20, 2020

User story

As an end-user, I want to receive relevant toast notifications, so that I can tell which state of the application I am currently interacting with.

Acceptance criteria / bug explanation

The toast notification in the onMove() method of the joystick in MainActivity is reposted every time the joystick is moved. The onMove() can happen a large number of times before the end-user lets go of the joystick. This means that the toast message prompting the user to connect the car before using the joystick is printed too many times (should only be once), and remains on screen for ages.

This should be considered a bug, even though the system it is technically doing exactly what we told it to.

If it can be fixed, that would be nice :)

@livmari livmari added the bug Something isn't working label May 20, 2020
@livmari livmari added this to the App back end milestone May 20, 2020
@ZJW-92
Copy link
Contributor

ZJW-92 commented May 20, 2020

I agree. I don't know if it work that I put switch case inside if else statements. I mean, if (!carIsConnected) {
pleaseConnectCar();
} else { switch case 1, switch case 2.... }}

@livmari
Copy link
Contributor Author

livmari commented May 31, 2020

@ZJW-92 , it won't work because everything is still within a method that activates on move screen touch. So the toast will be displayed multiplied by the on move time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants