Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Frontend App #23

Merged
merged 4 commits into from
Apr 16, 2021
Merged

Improve Frontend App #23

merged 4 commits into from
Apr 16, 2021

Conversation

kam56
Copy link
Contributor

@kam56 kam56 commented Apr 14, 2021 •
edited
Loading

Current features

  • The background picture, logo, and some other features are added.
  • A layout is prepared so that it shall be used as a template for the rest of the pages.

Future Improvements

  • The navigation menu is not responsive to the size of the window. But we will fix it while working on the relative user story.
  • Make the header sticky to the top while scrolling down.

Fixes #2

@kam56
Improve Frontend App
464b9d2 
##Current features
*The background picture, Logo and some other features are added.
*A layout is prepared so that it shall be used as template for the rest of the pages.

 ## Future Improvements

*The navigation menu on the manual control page is not responsive to the size of the window. But we will fix it while working on the relative user story.
*I tried to make the Header on the manual control page to be sticky to top while scrolling. But, it needs some java script. So, that is in our todo list.

Fixes #2
@kam56 kam56 added CSS CSS related task NodeJS NodeJS and ElectronJS related tasks labels Apr 14, 2021
@kam56 kam56 added this to the Front-end website milestone Apr 14, 2021
@kam56
Improve Frontend App
8b65005 
*The background picture, Logo and some other features are added.
*A layout is prepared so that it shall be used as template for the rest of the pages.

 ## Future Improvements

*Make the navigation menu as multi-level responsive menu.
*Make the Header sticky to top while scrolling down.

Fixes #2
@kam56 kam56 force-pushed the frontend-app-setup branch 2 times, most recently from b367c3f to 8b65005 Compare April 14, 2021 09:19
axe007
axe007 requested changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@axe007 axe007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's work more on the following items:

  • Main and child containers to optimize their width and ratio.
  • Menu control
  • Footer section height and adjustment
  • Create template pages for all section.

I will update you all tomorrow. Thanks.

@axe007
Merge branch 'frontend-app-setup' of https://github.com/DIT112-V21/gr…
5561a96 
…oup-09 into frontend-app-setup
@axe007
Implement frontend app generic layouts
11d3060 
## Completed tasks:
- Layouts and styles had created for all frontend app pages.
- Moved stylesheets, fonts and images to assets folder.
- All pages are linked and created with filler content.

Resolves: #2
nikalc
nikalc reviewed Apr 16, 2021
View reviewed changes
Copy link
Contributor

@nikalc nikalc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

OneMoreOreo
OneMoreOreo approved these changes Apr 16, 2021
View reviewed changes
Copy link
Contributor

@OneMoreOreo OneMoreOreo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frontend App updates approved.

Adds very good looking updates.

@axe007 axe007 merged commit 254ec46 into master Apr 16, 2021
@axe007 axe007 deleted the frontend-app-setup branch April 16, 2021 16:09
@axe007 axe007 linked an issue Apr 19, 2021 that may be closed by this pull request
1.4 Frontend centered functionalities #31
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikalc nikalc nikalc left review comments

@axe007 axe007 axe007 approved these changes

@OneMoreOreo OneMoreOreo OneMoreOreo approved these changes

@ramadi-a ramadi-a Awaiting requested review from ramadi-a

Assignees

@axe007 axe007

Labels
CSS CSS related task NodeJS NodeJS and ElectronJS related tasks
Projects
SmartRover Scrum Board
Awaiting triage
Milestone
Front-end website
Development

Successfully merging this pull request may close these issues.

1.4 Frontend centered functionalities Frontend app setup
4 participants
@kam56 @axe007 @nikalc @OneMoreOreo