Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement data exchange #70

Merged
merged 2 commits into from
Apr 30, 2021
Merged

Implement data exchange #70

merged 2 commits into from
Apr 30, 2021

Conversation

nikalc
Copy link
Contributor

@nikalc nikalc commented Apr 30, 2021

  • Improved button actions for Satellite and cruise control

Next:

  • Test further to improve
  • More user friendly option improvements if possible

@nikalc
Implement data exchange
d782fd2 
Fixed:
- Serial feedback works
- Satellite and cruise control button actions defined
- Action related indicators implemented
- Data to and from rover have separated

Fixes #11
@nikalc
Update comm javascript
dedbc7c 
Related updates for satellite and cruise control

Fixes #11
@nikalc nikalc added sprint-2 User stories & bugs for TBD on sprint 2 JS Javascript work CSS CSS related task NodeJS NodeJS and ElectronJS related tasks mqtt Tasks carried over MQTT protocol M2 Milestone 2 related issues labels Apr 30, 2021
@nikalc nikalc requested a review from axe007 April 30, 2021 10:26
@nikalc nikalc self-assigned this Apr 30, 2021
axe007
axe007 approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@axe007 axe007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good update.

Let's discuss how we can make our JS logic for CSS change. For now, I'm bit out of ideas. Thanks.

@nikalc nikalc merged commit ca2b215 into master Apr 30, 2021
@axe007 axe007 deleted the info-data-exchange branch May 1, 2021 10:17
@axe007 axe007 linked an issue May 27, 2021 that may be closed by this pull request
Get info/data from the SmartRover #11
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axe007 axe007 axe007 approved these changes

Assignees

@nikalc nikalc

Labels
CSS CSS related task JS Javascript work M2 Milestone 2 related issues mqtt Tasks carried over MQTT protocol NodeJS NodeJS and ElectronJS related tasks sprint-2 User stories & bugs for TBD on sprint 2
Projects
SmartRover Scrum Board
Awaiting triage
Milestone
Communicating with the emulator
Development

Successfully merging this pull request may close these issues.

Get info/data from the SmartRover
2 participants
@nikalc @axe007