Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vice.com topics #15694

Closed
1 task done
K33k0 opened this issue May 24, 2024 · 1 comment · Fixed by #15698
Closed
1 task done

Vice.com topics #15694

K33k0 opened this issue May 24, 2024 · 1 comment · Fixed by #15698
Labels
RSS proposal New RSS wanted

Comments

@K33k0
Copy link
Contributor

K33k0 commented May 24, 2024

Category

New media

Website URL

https://www.vice.com

Website description

vice.com a traditional media news

What content should be included?

latest feed of various topics

Additional description

Creating so I can fill in the PR

This is not a duplicated rss request
@K33k0 K33k0 added the RSS proposal New RSS wanted label May 24, 2024
@K33k0 K33k0 mentioned this issue May 24, 2024
Closed
9 tasks
@K33k0
Copy link
Contributor Author

K33k0 commented May 24, 2024

I initially messed up the PR. However after editing the title and updating the routes, it looks to be passing all tests.

K33k0 added a commit to K33k0/RSSHub that referenced this issue May 24, 2024
@K33k0
feat: adds vice.com route DIYgod#15694
92b1d2b
@K33k0 K33k0 mentioned this issue May 24, 2024
Merged
9 tasks
TonyRL pushed a commit that referenced this issue May 26, 2024
@K33k0
feat: adds vice.com route #15694 (#15698)
d33b416 
* feat: adds vice.com route #15694

* Clean up ctx parameters

Co-authored-by: Tony <TonyRL@users.noreply.github.com>

* remove obsolete feature config

Co-authored-by: Tony <TonyRL@users.noreply.github.com>

* Updates route to combat future conflicts. removes content Parameter

Co-authored-by: Tony <TonyRL@users.noreply.github.com>

* removes unnecessary language parameter fallback

Co-authored-by: Tony <TonyRL@users.noreply.github.com>

* replaces html parsing with json data parsing

Co-authored-by: Tony <TonyRL@users.noreply.github.com> - amazing code thanks for your contribution (never had someone comment on my code before, hope I've implemented your suggestions the right way)

* Updates the article content, to pull by default

Co-authored-by: Tony <TonyRL@users.noreply.github.com>. I've had to update it a little as there were a few errors

* Updates example & radar

* consolidates similar role cases

Co-authored-by: Tony <TonyRL@users.noreply.github.com>

* Renames namespace name

Co-authored-by: Tony <TonyRL@users.noreply.github.com>

* Removes article rendering

Whilst _some_ main articles do benefit from inner article rendering, it was inserting irrelevant content (ads for similar content). The articles that do benefit are essentally just listicles.

---------
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
RSS proposal New RSS wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: adds vice.com route #15694 K33k0/RSSHub
feat: Implements new route for vice.com (topics)
1 participant
@K33k0