-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prime Number Cache Performance Testing Improvement #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rely on Statistics package for calculating StandardDeviation, eliminate duplicated code
* Extract targetedAccessTest from BytePrimeCacheTest Update BytePrimeCacheTest: * Refactor prime number list to be public and static, accessible from PerformanceTest class
* Add Statistics import for easy data summary * Create FindPrime method test case, which collects nanosecond time measurements for various prime number search cases
* Code style / format correction
DK96-OS
added
bug
Something isn't working
documentation
Improvements or additions to documentation
labels
Jul 5, 2021
* Create Print function for processing and displaying time results * Improve FindPrime Test stability by wrapping in a coroutine * Refactor TargetedAccess Test to use new measurement process
* Fix PrintTestResults, now removing the 3 longest measurements * Wrapped TargetedAccess Test in coroutines
* Create IsPrime Test case with a range of parameters * Add more Parameters to existing test cases to collect more data, doubling certain parameters with a high variance
* Remove Coroutines after determining that they have no visible impact on the test results * Cleanup unused imports, including removing assertions, as this test class is not concerned with correctness
* Add Java versions 14, 15, 16
* Remove unused import
Consider that:
These statements, while true, justify removing support for 8, and adding support for 16. |
* Remove java version 8, add version 16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve performance testing by recording small, independent time measurements, and then performing statistical analysis to determine the reliability of each measurement.