Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly broadcast inputs in VaryingCelestialTransform #160

Merged
merged 11 commits into from
Mar 2, 2022

Conversation

Cadair
Copy link
Member

@Cadair Cadair commented Mar 1, 2022

This should add support for all possible array shapes of inputs, including when calculating world coordinates for all pixel coordinates

@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #160 (b6649ee) into main (e9d54e7) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
+ Coverage   95.45%   95.57%   +0.12%     
==========================================
  Files          27       27              
  Lines        1165     1197      +32     
==========================================
+ Hits         1112     1144      +32     
  Misses         53       53              
Impacted Files Coverage Δ
dkist/wcs/models.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9d54e7...b6649ee. Read the comment docs.

@Cadair Cadair merged commit 5de6264 into DKISTDC:main Mar 2, 2022
@Cadair Cadair deleted the models_broadcasting branch March 2, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant