Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Result paging #212

Merged
merged 7 commits into from
Dec 13, 2022
Merged

Result paging #212

merged 7 commits into from
Dec 13, 2022

Conversation

Cadair
Copy link
Member

@Cadair Cadair commented Dec 13, 2022

The default page size is 20 so it was super easy to not get all the results.

note: I will write tests for this at a later date 💸

fixes #112

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #212 (38107f1) into main (137067f) will decrease coverage by 0.05%.
The diff coverage is 94.87%.

❗ Current head 38107f1 differs from pull request most recent head ac065d6. Consider uploading reports for the commit ac065d6 to get more accurate results

@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
- Coverage   96.46%   96.40%   -0.06%     
==========================================
  Files          29       29              
  Lines        1527     1559      +32     
==========================================
+ Hits         1473     1503      +30     
- Misses         54       56       +2     
Impacted Files Coverage Δ
dkist/net/client.py 97.70% <91.66%> (-1.40%) ⬇️
dkist/net/__init__.py 100.00% <100.00%> (ø)
dkist/net/attr_walker.py 100.00% <100.00%> (ø)
dkist/net/attrs.py 98.83% <100.00%> (+0.08%) ⬆️
dkist/utils/inventory.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@eigenbrot eigenbrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing major

dkist/net/client.py Outdated Show resolved Hide resolved
dkist/net/client.py Outdated Show resolved Hide resolved
dkist/net/attr_walker.py Show resolved Hide resolved
dkist/net/attrs.py Show resolved Hide resolved
@Cadair Cadair enabled auto-merge (squash) December 13, 2022 16:48
@Cadair Cadair merged commit b941dec into DKISTDC:main Dec 13, 2022
@Cadair Cadair deleted the result_paging branch December 13, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deal with the result limit on the dataset endpoint
2 participants