Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add codspeed workflow to run benchmarks #382

Merged
merged 45 commits into from
May 9, 2024
Merged

Add codspeed workflow to run benchmarks #382

merged 45 commits into from
May 9, 2024

Conversation

SolarDrew
Copy link
Contributor

Adds a workflow to run Codspeed. Supercedes #372 , as this will hopefully be easier to setup and maintain, and give nicer output, a la codecov.

@SolarDrew
Add very very basic benchmark test just to get things rolling
593b672
@SolarDrew
Add tox env
de7ef0b
@SolarDrew
Add benchmarks tox env to gh jobs list
dac0e20
@SolarDrew
Move unzipping out of benchmark to just measure opening the asdf
a99d255
@SolarDrew
Pull benchmark data for latest release and compare
bfc31c5
@SolarDrew
Add tox env for benchmarking main and tweak not-main benchmark run
76e4e92
@SolarDrew
Add workflow to run benchmarks on main
b6d0792 
No idea if this will work
@SolarDrew
Make file copying work in tox
82332ea
@SolarDrew
Make github workflow push main benchmark results to repo
0d59140
@SolarDrew
Make some steps towards getting gh worklow working
2edc30d
@SolarDrew
Need to actually push changes for github workflow to see them
075e6de 
Which is annoying since it was exactly not the point
@SolarDrew
Make workflow push benchmark to repo
3e3cafd
@SolarDrew
Make tox do it instead
234af5d
@SolarDrew
Using different version of Python for workflow and local clearly a ba…
36bd260 
…d idea
@SolarDrew
Committing needs user config
fe83f56
@SolarDrew
Need to know why push isn't working
31895ed
@SolarDrew
Try disabling git terminal prompts
18700f2
@SolarDrew
Well that hasn't helped, it just errors instead of hanging
ddde74a
@SolarDrew
Try doing the git bit in the workflow instead again
831c41d
@SolarDrew
Share volumes across docker images so we can commit results in the wo…
fae780a 
…rkflow
@SolarDrew
Move benchmark workflow out of main tox action into codspeed
1807001 
Let's see how this goes
@SolarDrew
Need to actually install the repo, that will help
c834e31
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented May 8, 2024 •
edited

CodSpeed Performance Report

Congrats! CodSpeed is installed 🎉

🆕 7 new benchmarks were detected.

You will start to see performance impacts in the reports once the benchmarks are run from your default branch.

Detected benchmarks
  • test_load_asdf (9.7 s)
  • test_plot_dataset[axes0] (72.4 s)
  • test_plot_dataset[axes1] (10.9 s)
  • test_plot_dataset[axes2] (14.7 s)
  • test_plot_dataset[axes3] (74.2 s)
  • test_plot_dataset[axes4] (17.2 s)
  • test_plot_dataset[axes5] (15 s)

@SolarDrew SolarDrew mentioned this pull request May 8, 2024
Closed
Cadair
Cadair reviewed May 8, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
.github/workflows/codspeed.yml Outdated Show resolved Hide resolved
.github/workflows/codspeed.yml Outdated Show resolved Hide resolved
tox.ini Show resolved Hide resolved
SolarDrew and others added 13 commits May 8, 2024 14:21
@Cadair
Copy link
Member

Cadair commented May 8, 2024

pre-commit.ci autofix

@Cadair Cadair merged commit 448787d into DKISTDC:main May 9, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cadair Cadair Cadair approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SolarDrew @Cadair