Cmesh vtk data set translator [vtk_to_cmesh 6/6] #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 8, 2023 13:23
…d and Polydata Added an Example, a good googletest is still missing
15 tasks
|
@Davknapp Please resolve merge conflicts. |
jmark
requested changes
May 12, 2023
jmark
approved these changes
May 12, 2023
jfussbro
pushed a commit
to jfussbro/t8code
that referenced
this pull request
Jun 27, 2023
Cmesh vtk data set translator [vtk_to_cmesh 6/6]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full implementation of the vtk-reader.
Added a function that constructs a cmesh given a SmartPointer to a vtkDataSet, that either describes a vtkUnstructuredGrid or a vtkPolyData.
vtkDataSet is the baseclass of vtkUnstructuredGrid and vtkPolyData - therefore it should be possible to extend the vtkReader by providing a reader for other file-types that describe a vtkDataSet in the future.
All these boxes must be checked by the reviewers before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
The author added a BSD statement to
doc/(or already has one)The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
All tests pass (in various configurations, this should be executed automatically in a github action)
New source/header files are properly added to the Makefiles
New Datatypes are added to t8indent_custom_datatypes.txt
The reviewer executed the new code features at least once and checked the results manually
The code is covered in an existing or new test case
New tests use the Google Test framework
The code follows the t8code coding guidelines
The code is well documented
All function declarations, structs/classes and their members have a proper doxygen documentation
All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)
If a new directory with source-files is added, it must be covered by the
script/find_all_source_files.scpto check the indentation of these files.If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.