Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmesh vtk data set translator [vtk_to_cmesh 6a/6] #539

Merged
merged 12 commits into from
Jun 22, 2023

Conversation

ililikakis
Copy link
Contributor

@ililikakis ililikakis commented May 3, 2023

Describe your changes here:

Restructuring some vtk files by adding new directory src/t8_vtk/.

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually

  • The code follows the t8code coding guidelines

  • New source/header files are properly added to the Makefiles

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

Tests

  • The code is covered in an existing or new test case using Google Test

Github action

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

  • All tests pass (in various configurations, this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)

Scripts and Wiki

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • New Datatypes are added to t8indent_custom_datatypes.txt
  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

Licence

  • The author added a BSD statement to doc/ (or already has one)

@ililikakis ililikakis assigned ililikakis and Davknapp and unassigned ililikakis May 4, 2023
Copy link
Collaborator

@Davknapp Davknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, but it would add a lot of changes to PR #467 and we prefer to keep PRs small. Therefore, I propose to wait until 467 is merged.

@Davknapp Davknapp marked this pull request as draft May 5, 2023 07:02
Base automatically changed from cmesh_vtk_DataSet_translator to main May 12, 2023 11:48
@ililikakis ililikakis assigned ililikakis and unassigned Davknapp May 15, 2023
@ililikakis ililikakis assigned Davknapp and unassigned ililikakis May 15, 2023
@Davknapp Davknapp marked this pull request as ready for review May 15, 2023 11:06
@Davknapp Davknapp merged commit 10840ae into main Jun 22, 2023
3 checks passed
@Davknapp Davknapp deleted the cmesh_vtk_DataSet_translator_ext branch June 22, 2023 10:02
jfussbro pushed a commit to jfussbro/t8code that referenced this pull request Jun 27, 2023
…tor_ext

Cmesh vtk data set translator [vtk_to_cmesh 6a/6]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants