Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cctextures): Adapts cctextures loader to new filenames #993

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

cornerfarmer
Copy link
Member

@cornerfarmer cornerfarmer commented Oct 17, 2023

Fixes: #992

@cornerfarmer
Copy link
Member Author

cornerfarmer commented Oct 17, 2023

BlenderProcHelper result for run 535:

Done with: [amass_human_poses_python 35s, auto_shading_python 9s, basic_python 14s, blenderkit_python 20s, bop_object_on_surface_sampling_python 95s, bop_object_physics_positioning_python 124s, bop_object_pose_sampling_python 43s, bop_scene_replication_python 173s, camera_depth_of_field_python 20s, camera_object_pose_python 16s, camera_random_trajectories_python 52s, camera_sampling_python 20s, coco_annotations_python 15s, diffuse_color_image_python 18s, dust_python 29s, entity_displacement_modifier_python 14s, entity_manipulation_python 10s, front_3d_object_sampling_python 85s, front_3d_python 103s, front_3d_with_improved_mat_python 105s, git_log 1s, haven_python 22s, ikea_python 18s, kinect_azure_noise_python 14s, lens_distortion_python 15s, lens_distortion_python 13s, light_sampling_python, material_manipulation_python 10s, material_randomizer_python 14s, matterport3d_python 71s, motion_blur_rolling_shutter_python 31s, motion_blur_rolling_shutter_python 25s, multi_render_python 256s, nocs_python 18s, object_pose_sampling_python 10s, on_surface_object_sampling_python 10s, optical_flow_python 24s, physics_convex_decomposition_python 126s, physics_positioning_python 22s, pix3d_python 16s, random_backgrounds_python 17s, random_room_constructor_python 86s, replica_python 356s, scenenet_python 54s, scenenet_with_cctextures_python 55s, semantic_segmentation_python 15s, shapenet_python, shapenet_with_scenenet_python 58s, shapenet_with_suncg_python 67s, spotlight_python 18s, stereo_matching_python 43s, stereo_matching_with_projector_python 146s, suncg_basic_python 32s, suncg_with_cam_sampling_python 59s, suncg_with_improved_mat_python 78s, suncg_with_object_replacer_python 62s, tests_python 20s, urdf_loading_and_manipulation_python 51s]
Done with 58 of 58 tests.
There were errors:
Unit tests output:

...........
----------------------------------------------------------------------
Ran 11 tests in 14.905s

OK

stereo_matching (main_python)

The output of stereo_matching:main_python:disparity has changed: Diff: 0.0832, Pixel diff: 0.0253



Compare image Newly generated image

The output of stereo_matching:main_python:stereo-depth has changed: Diff: 0.0052, Pixel diff: 0.0246



Compare image Newly generated image

The output of stereo_matching:main_python:disparity has changed: Diff: 0.2156, Pixel diff: 0.0516



Compare image Newly generated image

The output of stereo_matching:main_python:stereo-depth has changed: Diff: 0.0122, Pixel diff: 0.0514



Compare image Newly generated image

stereo_matching_with_projector (main_python)

The output of stereo_matching_with_projector:main_python:disparity has changed: Diff: 0.0102, Pixel diff: 0.0041



Compare image Newly generated image

The output of stereo_matching_with_projector:main_python:disparity has changed: Diff: 0.0111, Pixel diff: 0.0085



Compare image Newly generated image

Pylint output

Expand

Messages

Module blenderproc.python.loader.CCMaterialLoader (blenderproc/python/loader/CCMaterialLoader.py)

Line Col. Type Symbol ID Obj Message
72 0 convention line-too-long C0301
Line too long (152/120)

Module blenderproc.python.writer.BopWriterUtility (blenderproc/python/writer/BopWriterUtility.py)

Line Col. Type Symbol ID Obj Message
15 0 convention wrong-import-order C0411
standard import "import sys" should be placed before "import numpy as np"

Metrics

Count per types

Name Count
convention 2

Count per messages

Name Count
line-too-long 1
wrong-import-order 1

Count per modules

Name Count
blenderproc.python.loader.CCMaterialLoader 1
blenderproc.python.writer.BopWriterUtility 1

Count per path

Name Count
blenderproc/python/loader/CCMaterialLoader.py 1
blenderproc/python/writer/BopWriterUtility.py 1
***The tests are done.*** Check the log:

Last update: 10/17/2023, 13:18:09

@cornerfarmer cornerfarmer merged commit c0d689b into main Oct 17, 2023
3 checks passed
@cornerfarmer cornerfarmer deleted the iss992_cctextures_filename_changes branch October 17, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bproc.loader.load_ccmaterials returns empty list
1 participant