Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System info helper #613

Merged
merged 8 commits into from
Oct 18, 2021
Merged

System info helper #613

merged 8 commits into from
Oct 18, 2021

Conversation

araffin
Copy link
Member

@araffin araffin commented Oct 16, 2021

Description

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

closes #612

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)
  • I have checked that the documentation builds using make doc (required)

Note: You can run most of the checks using make commit-checks.

Note: we are using a maximum length of 127 characters per line

Copy link
Collaborator

@Miffyli Miffyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small-ish comments, mostly LGTM!

docs/misc/changelog.rst Outdated Show resolved Hide resolved
stable_baselines3/common/utils.py Outdated Show resolved Hide resolved
stable_baselines3/common/utils.py Outdated Show resolved Hide resolved
stable_baselines3/common/save_util.py Outdated Show resolved Hide resolved
stable_baselines3/common/save_util.py Show resolved Hide resolved
tests/test_utils.py Outdated Show resolved Hide resolved
stable_baselines3/common/base_class.py Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.md Show resolved Hide resolved
Copy link
Collaborator

@Miffyli Miffyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after addressing the (derp) comments! Not merging yet in case you want to change something small.

@araffin araffin merged commit 1564a85 into master Oct 18, 2021
@araffin araffin deleted the feat/save-versions branch October 18, 2021 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add relevant package versions to saved file
2 participants