-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gym 0.26 support #780
Closed
Closed
Add Gym 0.26 support #780
Changes from 13 commits
Commits
Show all changes
201 commits
Select commit
Hold shift + click to select a range
ee71299
Remove references to GoalEnv
carlosluis 65343f5
Fix env tests
carlosluis 4d794f3
Fix bug in test creating invalid box space
carlosluis 513ed08
Add classic_control extra packages from gym
carlosluis 861b612
Merge branch 'master' into fix_tests
araffin 2277012
Merge branch 'master' into fix_tests
carlosluis e5195a0
Change back to gym 0.22 for testing
carlosluis 435f5fb
Fix failing set_env test
carlosluis f64346a
Fix test failiing due to deprectation of env.seed
carlosluis 9efc37b
Merge branch 'master' into fix_tests
carlosluis daaa84c
Adjust mean reward threshold in failing test
carlosluis e62edde
Fix her test failing due to rng
carlosluis 9a41c51
Change seed and revert reward threshold to 90
carlosluis 41f260b
Merge branch 'master' into fix_tests
carlosluis 9c73732
Pin gym version
carlosluis 110be78
Make VecEnv compatible with gym seeding change
carlosluis dc9c645
Revert change to VecEnv reset signature
carlosluis e1c6e1b
Change subprocenv seed cmd to call reset instead
carlosluis 29bd222
Fix type check
carlosluis b1730f4
Add backward compat
araffin 3297091
Merge branch 'master' into fix_tests
araffin 00e7946
Add `compat_gym_seed` helper
araffin ecf02ce
Merge branch 'master' into fix_tests
araffin f0e1ccb
Merge branch 'master' into fix_tests
carlosluis a116a1a
Add goal env checks in env_checker
carlosluis 8780919
Add docs on HER requirements for envs
carlosluis e0db1ed
Merge branch 'master' into fix_tests
carlosluis ff44a2f
Merge branch 'master' into fix_tests
araffin c2ab5cd
Capture user warning in test with inverted box space
carlosluis cb50e9e
Update ale-py version
araffin de3f086
Fix randint
araffin 1980db2
Allow noop_max to be zero
araffin 85087bc
Merge branch 'master' into fix_tests
araffin 776217a
Merge branch 'master' into fix_tests
araffin fa40152
Merge branch 'master' into fix_tests
araffin 90adf8f
Update changelog
araffin d0300c8
Merge branch 'master' into fix_tests
araffin 25136d7
Merge branch 'master' into fix_tests
araffin ec9d50f
Merge branch 'master' into fix_tests
araffin 0f240fa
Update docker image
araffin a6766bd
Merge branch 'fix_tests' of github.com:carlosluis/stable-baselines3 i…
araffin 3087d58
Update doc conda env and dockerfile
araffin 7629016
Custom envs should not have any warnings
araffin 7bb643b
Fix test for numpy >= 1.21
araffin 706f072
Add check for vectorized compute reward
araffin af8e51b
Merge branch 'master' into fix_tests
araffin 77d188f
Bump to gym 0.24
araffin 68cec40
Fix gym default step docstring
araffin 0072b77
Test downgrading gym
araffin 07a85b8
Revert "Test downgrading gym"
araffin d755cc6
Fix protobuf error
araffin 99b91eb
Fix in dependencies
araffin 1d7da08
Fix protobuf dep
araffin f205865
Merge branch 'master' into fix_tests
araffin cf7e438
Use newest version of cartpole
araffin 3d6f28a
Merge branch 'master' into fix_tests
araffin 626db1d
Update gym
araffin f864501
Fix warning
araffin 3af1488
Merge branch 'master' into fix_tests
araffin 5fa3cd9
Loosen required scipy version
araffin e79148b
Scipy no longer needed
araffin ebf73d6
Merge branch 'master' into fix_tests
araffin 1ad5f78
Try gym 0.25
araffin 3f0b531
Silence warnings from gym
araffin 2fc09f7
Merge branch 'master' into fix_tests
araffin b27e555
Filter warnings during tests
araffin c1e01c9
Merge branch 'master' into fix_tests
araffin 78ef1e4
Merge branch 'master' into fix_tests
araffin c4bf066
Merge branch 'master' into fix_tests
araffin ed0f79e
Merge branch 'master' into fix_tests
araffin ee52936
Merge branch 'master' into fix_tests
araffin 5d3b07f
Merge branch 'master' into fix_tests
araffin 99d2155
Merge branch 'master' into fix_tests
araffin a0d5c79
Merge branch 'master' into fix_tests
qgallouedec 75fd27e
Merge branch 'master' into fix_tests
araffin 8c65748
Update doc
araffin 0874da1
Update requirements
araffin 26ceefc
Add gym 26 compat in vec env
araffin a8c579a
Fixes in envs and tests for gym 0.26+
araffin 6ed3079
Enforce gym 0.26 api
araffin 0851440
Merge pull request #1 from carlosluis/fix_tests
tlpss 95bb4d6
format
tlpss c4517f2
Fix formatting
araffin 9ac7592
Fix dependencies
araffin d2e6873
Fix syntax
araffin 969c1cf
Cleanup doc and warnings
araffin 2fcd072
Faster tests
araffin dd67a20
Higher budget for HER perf test (revert prev change)
araffin ae04b20
Merge branch 'master' into fix_tests
araffin 9ae6fa2
Fixes and update doc
araffin 056454b
Fix doc build
araffin f9bbb29
Merge branch 'master' into fix_tests
araffin 29dffed
Merge branch 'master' into fix_tests
araffin cf565d9
Merge branch 'master' into fix_tests
araffin ed191b0
Merge branch 'master' of https://github.com/DLR-RM/stable-baselines3 …
qgallouedec 04aa926
Merge branch 'master' into fix_tests
araffin 734e19f
Merge branch 'master' into fix_tests
araffin 9ad927b
Fix breaking change
araffin 3ca1b73
Fixes for rendering
araffin 0f5374f
Rename variables in monitor
araffin 9cf2c3d
Merge pull request #2 from carlosluis/fix_tests
tlpss 3320e78
update render method for gym 0.26 API
tlpss 1596ea4
update tests and docs to new gym render API
tlpss b4b911c
Merge branch 'master' into fix_tests
araffin 008fdce
undo removal of render modes metatadata check
tlpss 93bd988
set rgb_array as default render mode for gym.make
tlpss c9a29b9
Merge branch 'master' into fix_tests
araffin 720317f
Merge branch 'master' into fix_tests
araffin 53da2d0
undo changes & raise warning if not 'rgb_array'
tlpss 8675011
Merge branch 'master' into fix_tests
araffin db81278
Merge branch 'master' into fix_tests
araffin 54fb37e
Fix type check
araffin 96793b9
Merge branch 'fix_tests' into fix_tests
araffin e30c117
Merge branch 'master' into fix_tests
qgallouedec 07ca271
Remove recursion and fix type checking
araffin acd0420
Merge branch 'master' into fix_tests
araffin c0a6a18
Remove hacks for protobuf and gym 0.24
araffin b954703
Fix type annotations
araffin 870139c
reuse existing render_mode attribute
tlpss bc5335f
return tiled images for 'human' render mode
tlpss c718106
Merge branch 'fix_tests' of https://github.com/carlosluis/stable-base…
tlpss 11cf07f
Allow to use opencv for human render, fix typos
araffin 9d91ea3
Merge pull request #4 from tlpss/tlss/fix_tests
araffin 3f75a8a
Add warning when using non-zero start with Discrete (fixes #1197)
araffin 08a4712
Merge branch 'master' into fix_tests
araffin 93c86f2
Merge branch 'master' into fix_tests
araffin d35cfad
Merge branch 'master' into fix_tests
araffin 6251fdc
Fix type checking
araffin be998e8
Merge branch 'fix_tests' of github.com:carlosluis/stable-baselines3 i…
araffin d24d30d
Merge branch 'fix_tests' into tlpss/fix_tests
araffin 6b80c93
Bug fixes and handle more cases
araffin c09fa74
Throw proper warnings
araffin 480a793
Update test
araffin e03b885
Fix new metadata name
araffin e4248df
Ignore numpy warnings
araffin 16bb26b
Merge branch 'fix_tests' into tlpss/fix_tests
araffin 1f8ccbe
Fixes in vec recorder
araffin f4e978a
Global ignore
araffin 408e9c2
Merge branch 'fix_tests' into tlpss/fix_tests
araffin f98903a
Filter local warning too
araffin 046c12b
Merge branch 'fix_tests' into tlpss/fix_tests
araffin 595be86
Merge branch 'master' into fix_tests
araffin 29086a5
Monkey patch not needed for gym 26
araffin 254107a
Merge branch 'fix_tests' into tlpss/fix_tests
araffin 6103962
Merge branch 'master' into fix_tests
araffin fbaa8ac
Merge branch 'fix_tests' into tlss/fix_tests
araffin 20faf11
Merge branch 'master' into fix_tests
araffin 01831b6
Merge branch 'master' into fix_tests
araffin 3780476
Merge branch 'fix_tests' into tlpss/fix_tests
araffin 085b4c8
Merge branch 'fix_tests' of github.com:tlpss/stable-baselines3 into t…
araffin 6a3f45d
Add doc of VecEnv vs Gym API
araffin c645d49
Add render test
araffin 3cf4d00
Merge pull request #3 from tlpss/fix_tests
araffin 3f6413d
Fix return type
araffin ff609ad
Update VecEnv vs Gym API doc
araffin 99589ce
Add note in the quickstart section
araffin cf75cdc
Merge branch 'master' into fix_tests
araffin 3611f2c
Merge branch 'master' into fix_tests
araffin b428a27
Fix for custom render mode
araffin d98dc9e
Fix return type
araffin 5c32861
Merge branch 'master' into fix_tests
araffin 6eaecd2
Merge branch 'master' into fix_tests
araffin cd28666
Fix type checking
araffin 4f796a0
Merge branch 'master' into fix_tests
araffin 669ef02
Merge branch 'master' into fix_tests
araffin c9430ec
check test env test_buffer
qgallouedec 546928c
skip render check
qgallouedec 8462dbb
check env test_dict_env
qgallouedec 205b987
test_env test_gae
qgallouedec 1946082
check envs in remaining tests
qgallouedec 7460782
Update tests
araffin 0431c7a
Merge pull request #5 from DLR-RM/check_test_env
araffin e5575d8
Add warning for Discrete action space with non-zero (#1295)
araffin c951311
Merge branch 'master' into fix_tests
qgallouedec b787d98
Fix atari annotation
qgallouedec 85bb0d4
ignore get_action_meanings [attr-defined]
qgallouedec ba5827e
Merge branch 'master' into fix_tests
araffin afa1c73
Fix mypy issues
araffin f03fd75
Merge branch 'master' into fix_tests
araffin 40048ba
Merge branch 'master' into fix_tests
araffin 75217fa
Fix undefined info
araffin cff332c
Merge branch 'fix_tests' of github.com:carlosluis/stable-baselines3 i…
araffin 6da9b39
Merge branch 'master' into fix_tests
araffin 06ad5a8
Rename done to terminated
araffin 93c10cf
Fix pygame dependency for python 3.7
araffin c5a5d73
Merge branch 'master' into fix_tests
araffin 51ffad2
Merge branch 'master' into fix_tests
araffin 00b9bbb
Merge branch 'master' into fix_tests
araffin 8a149f4
Merge branch 'fix_tests' of github.com:carlosluis/stable-baselines3 i…
araffin b82cacd
Forks don't have access to private variables
araffin 07d2171
Merge branch 'master' into fix_tests
araffin d0f5e8a
Fix linter warnings
araffin d5c79b0
[ci skip] Merge branch 'master' into fix_tests
araffin e91b436
Merge branch 'master' into fix_tests
araffin 5ec7e39
Merge branch 'fix_tests' of github.com:carlosluis/stable-baselines3 i…
araffin 986e6c0
Fix env checker for GoalEnv
araffin 2be728d
Merge branch 'master' into fix_tests
araffin 331853a
Update env checker (more info) and fix dtype
araffin 68861b6
Use micromamab for Docker
araffin 9f0d5d8
Update dependencies
araffin 6617e6e
Clarify VecEnv doc
araffin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -73,7 +73,7 @@ | |
packages=[package for package in find_packages() if package.startswith("stable_baselines3")], | ||
package_data={"stable_baselines3": ["py.typed", "version.txt"]}, | ||
install_requires=[ | ||
"gym==0.21", # Fixed version due to breaking changes in 0.22 | ||
"gym>=0.21", | ||
"numpy", | ||
"torch>=1.8.1", | ||
# For saving models | ||
|
@@ -115,6 +115,7 @@ | |
"extra": [ | ||
# For render | ||
"opencv-python", | ||
"pygame", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
# For atari games, | ||
"ale-py~=0.7.4", | ||
"autorom[accept-rom-license]~=0.4.2", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would pin gym version again, unless we are sure no breaking changes is coming afterward...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There will be breaking API changes until 1.0, probably in a few more months. Any releases after will still likely result in some breaking changes, e.g. environment version bumps and so on.