Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positives in check, if wing cells can be trimmed rather than cut. #869

Open
joergbrech opened this issue Dec 21, 2021 · 2 comments
Open
Labels

Comments

@joergbrech
Copy link
Contributor

TiGL tries to determine if the geometry of a wing cell can be calculated by trimming a surface rather than cutting it with Boolean operations for a better performance. Currently, this check often has false positives and the trimmed result is wrong. The trimming is currently disabled in da2d269 and we should either remove the check completely or change it to be more reliable.

This is related to da2d269 and #865.

@joergbrech joergbrech added the bug label Dec 21, 2021
@condoratberlin
Copy link

Currently I would prefer to remove the checks, because the current version leads to wrong cell shapes.

@joergbrech
Copy link
Contributor Author

@condoratberlin thanks for the feedback. I will prepare a patch release of TiGL either this or next week where the checks are disabled. I will keep this issue open for documentation purposes. If there are no further issues with the disabled tests, we can remove the checks completely at a later stage (which would just be a refactoring of the source code, without any behavioral changes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants