Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inaccuracies when defining a wing cell border using ribs and spars #865

Closed
joergbrech opened this issue Dec 14, 2021 · 0 comments · Fixed by #866
Closed

Inaccuracies when defining a wing cell border using ribs and spars #865

joergbrech opened this issue Dec 14, 2021 · 0 comments · Fixed by #866

Comments

@joergbrech
Copy link
Contributor

The lax tolerances here:

TrimSpanwise(cache, SpanWiseBorder::Inner, m_positioningInnerBorder, 1e-2);
TrimSpanwise(cache, SpanWiseBorder::Outer, m_positioningOuterBorder, 1e-2);
TrimChordwise(cache, ChordWiseBorder::LE, m_positioningLeadingEdge, 1e-2);
TrimChordwise(cache, ChordWiseBorder::TE, m_positioningTrailingEdge, 1e-2);

lead to false positives, when the functions internally try to determine if the cell borders can be calculated by trimming a curve instead of using Boolean operations. This leads to inaccurate results.

It is very hard to decide on a good tolerance here and this is somewhat related to the monster #756, but for sure the tolerances have to be stricer than 1e-2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant