-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wing guide curve points x-direction does not respect wing transformation #975
Comments
joergbrech
added a commit
that referenced
this issue
Nov 21, 2023
Fix #975: Transform rX-Direction of guide curve with wing coordinate system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As a consequence the x and z coordinates of wing guide curve points are wrong if the wing coordinate system is rotated.
In the following line, the global x-direction is used:
tigl/src/wing/CTiglWingSegmentGuidecurveBuilder.cpp
Line 102 in bd9dca3
Here we should apply the wing transformation.
To reproduce: Open simple_test_guide_curves.xml and rotate the wing. This changes the shape of the wing:
Before rotation of the wing:
After rotation of the wing:
The text was updated successfully, but these errors were encountered: