Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #975: Transform rX-Direction of guide curve with wing coordinate system #976

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

merakulix
Copy link
Contributor

Description

Now the rX-Direction respects the wing coorddinate system

How Has This Been Tested?

Visual confirmation in TiGL Viewer and new unit test

Screenshots, that help to understand the changes(if applicable):

Checklist:

  • A test for the new functionality was added.
  • All tests run without failure.
  • The new code complies with the TiGL style guide.
  • New classes have been added to the Python interface.
  • API changes were documented properly in tigl.h.

@joergbrech joergbrech force-pushed the 975-guidecurve-coordinate-system branch from 1890397 to b07b40f Compare November 21, 2023 07:12
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2023

Codecov Report

Merging #976 (f8f027e) into master (5f3e172) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #976      +/-   ##
==========================================
+ Coverage   68.75%   68.90%   +0.15%     
==========================================
  Files         298      298              
  Lines       26479    26479              
==========================================
+ Hits        18206    18246      +40     
+ Misses       8273     8233      -40     
Files Coverage Δ
src/wing/CTiglWingSegmentGuidecurveBuilder.cpp 88.88% <100.00%> (ø)

... and 5 files with indirect coverage changes

@joergbrech joergbrech force-pushed the 975-guidecurve-coordinate-system branch from b07b40f to f8f027e Compare November 21, 2023 07:33
@joergbrech joergbrech merged commit 45a9428 into master Nov 21, 2023
16 of 17 checks passed
@joergbrech joergbrech deleted the 975-guidecurve-coordinate-system branch November 21, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants