918 update ci #945
Merged
918 update ci #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonReiswich
force-pushed
the
918-Update-CI
branch
from
8550ed2
to
4656721
Compare
joergbrech
force-pushed
the
918-Update-CI
branch
from
d5d6566
to
32d4f66
Compare
joergbrech
force-pushed
the
918-Update-CI
branch
2 times, most recently
from
3ade0d5
to
11fb948
Compare
joergbrech
force-pushed
the
918-Update-CI
branch
from
11fb948
to
c3c9da1
Compare
|
I think we've got it! @AntonReiswich, would you mind having a quick glimpse at my changes and merge, if you approve and CI finishes up successfully? |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #945 +/- ##
==========================================
- Coverage 69.56% 68.76% -0.81%
==========================================
Files 298 299 +1
Lines 25014 26483 +1469
==========================================
+ Hits 17401 18210 +809
- Misses 7613 8273 +660
|
|
That is great @joergbrech, thanks a lot! Sure, I'll look through it now! |
|
MacOS tests still seam to be flakey (this isn't a new issue, we had that problem before)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #918