Made Lofting algorithm throw Exception when side caps are invalid

[merakulix]

Description

Throwing an exception while building the shells, using invalid side caps, prevents TiGL to build invalid solid shapes.

How Has This Been Tested?

Added test in testFuselageStandardProfileRectangle.cpp that checks for exception if side caps are invalid. If rectangular profile wires are built that cannot be used to create valid side caps, the exception is thrown.

Screenshots, that help to understand the changes(if applicable):

This solid (created by a rectangle profile with too large corner radius) is not valid. Building side caps from its closed, but entangled profile wire is not possible. Solids like this will not be built and used mistakenly, if exception is thrown.

Checklist:

• A test for the new functionality was added.
• [x ] All tests run without failure.
• The new code complies with the TiGL style guide.
• New classes have been added to the Python interface.
• API changes were documented properly in tigl.h.

[joergbrech]

Looks good in principle. One unit tests triggers the new exception, see here. We should investigate and make sure that all unit tests succeed before we merge.

[joergbrech]

As per our chat on MM: Let's make sure that this doesn't affect the TiGL performance too much. One option could be to activate the test only in debug mode (and optionally: If we have the check in debug mode only, we could use simple assertions rather than exceptions. I believe this is common for checks that are only performed in debug mode)

[joergbrech]

Can we add a simple test where this exception is thrown? We can use the same preprocessor directive in the test that only checks if the lofter throws in debug mode.

[joergbrech]

Suggested change

	if(!BRepCheck_Analyzer(cap).IsValid()){
	throw CTiglError("Error occured while building side caps. Built shape invalid.");
	}
	#ifdef DEBUG
	if(!BRepCheck_Analyzer(cap).IsValid()){
	throw CTiglError("Error occured while building side caps. Built shape invalid.");
	}
	#endif