Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made Lofting algorithm throw Exception when side caps are invalid #999

Merged
merged 9 commits into from
Aug 30, 2024
Merged

Made Lofting algorithm throw Exception when side caps are invalid #999

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
42afdd5
made function throw exception
Feb 26, 2024
69761ef
added preprocessing directive
Jun 3, 2024
7cfbea9
Update src/geometry/CTiglPatchShell.cpp
merakulix Jul 4, 2024
961170e
Merge branch 'master' into MakeAddSideCapsThrowException
merakulix Jul 4, 2024
b8a6a45
add test for side caps
Jul 9, 2024
a7fc7ae
added test on warnings
Jul 23, 2024
1684a1a
merge master
Aug 29, 2024
838fa82
updated test
Aug 29, 2024
6c4fd02
uncommented preprocessing directive
Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/geometry/CTiglPatchShell.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
#include <StdFail_NotDone.hxx>
#include <BRepBuilderAPI_Sewing.hxx>
#include <Geom_Plane.hxx>
#include <BRepCheck_Analyzer.hxx>

namespace
{
Expand Down Expand Up @@ -70,6 +71,9 @@ void CTiglPatchShell::AddSideCap(TopoDS_Wire const& boundaryWire)
BRepBuilderAPI_FindPlane Searcher( boundaryWire, _tolerance );
if (Searcher.Found()) {
cap = BRepBuilderAPI_MakeFace(Searcher.Plane(), boundaryWire);
if(!BRepCheck_Analyzer(cap).IsValid()){
throw CTiglError("Error occured while building side caps. Built shape invalid.");
}
merakulix marked this conversation as resolved.
Show resolved Hide resolved
Ok = true;
}
else {
Expand All @@ -78,6 +82,11 @@ void CTiglPatchShell::AddSideCap(TopoDS_Wire const& boundaryWire)
if (MF.IsDone())
{
cap = MF.Face();
#ifdef DEBUG
if(!BRepCheck_Analyzer(cap).IsValid()){
throw CTiglError("Error occured while building side caps. Built shape invalid.");
}
#endif
Ok = true;
}
}
Expand Down
Loading