This repository has been archived by the owner on Dec 26, 2022. It is now read-only.
Refactor various request data types of APIs #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 11, 2019 12:19
Refactor api_find_txn_by_tag to use request data type from entangled. Remove unused functions and related test case.
Refactor api_get_transaction_msg to use request data type from entangled. Remove unused functions and related test case.
Remove ta_get_tips since it is not used anymore. get_tips and get_transaction_to_approve API should call native methods instead.
jserv
reviewed
Jan 11, 2019
| @@ -135,14 +99,11 @@ void test_serialize_ta_find_transactions_by_tag(void) { | |||
| int main(void) { | |||
| UNITY_BEGIN(); | |||
|
|
|||
| RUN_TEST(test_deserialize_ta_get_tips); | |||
There was a problem hiding this comment.
Would you append new test items accordingly?
There was a problem hiding this comment.
serializers from entangled has their own test cases there. And mock API tests remain same.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to update entangled version would encounter further memory free up problems, we refactor following APIs and corresponding request data type to original from entangled and remove unused functions/test cases: