[BUGFIX] Automatically create the assets and cache directories #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TYPO3 10LTS does not automatically create the directories set as `createDirs` in the `ext_emconf.php`. So to make sure files can be written to these directories (which fixes a crash in the frontend), the directories need to be checked and created before writing to them.
|
@oliverklee Thx for the pull request. Could you please optimize one little thing and change Environment::getPublicPath().'typo3temp/mkforms' to Environment::getProjectPath().'var/cache/code/mkforms' when you are at it? |
|
@hannesbochmann I'd prefer to have that change in a separate PR. Then we'll have the bug fix and the behavior change clearly separated. (We'll then also need to think about the consequences as the assets need to be in the public path so they can be accessed by the browser.) Would that be okay with you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPO3 10LTS does not automatically create the directories set as
createDirsin theext_emconf.php. So to make sure files canbe written to these directories (which fixes a crash in the frontend),
the directories need to be checked and created before writing to them.