New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cptbox: don't allow paths that don't exist #1010
Conversation
Basically, instead of checking that rules are correctly written when they are compiled into the jail, we should just check at construction time.
This is mostly for compatability with landlock, which enforces this.
7137c54
to
eff870d
Compare
Codecov Report
@@ Coverage Diff @@
## master #1010 +/- ##
==========================================
+ Coverage 81.06% 84.08% +3.01%
==========================================
Files 140 140
Lines 4754 4775 +21
==========================================
+ Hits 3854 4015 +161
+ Misses 900 760 -140
Continue to review full report at Codecov.
|
Are you sure Rust doesn't need a cache directory? What does it do when it doesn't have one? |
eff870d
to
01df1c9
Compare
Do you mean |
I don't think so, but it's worth checking? I know the first compile during autoconf takes a long time, because it has to download a bunch of crates that then get cached. |
01df1c9
to
68713d0
Compare
RUST passes in CI under this patch. I'm not really sure what it's doing though, and I was having trouble testing this locally. I think docker is re-using my old volumes, or something. Do you have any tips for how I should go about testing this? |
68713d0
to
a77702c
Compare
Try running |
Some compilers require directories to write to, specifically, ZIG and SWIFT require `.cache`
a77702c
to
df90c9e
Compare
Rust actually has |
Actually, if we aren't in Docker, we should create .cargo right? Is it worth adding then? |
I don't want to particularly support running outside of Docker, it's too much of a hassle. Users are on their own if they do so anyway. |
Specifically: Cargo installs to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is mostly for compatibility with landlock, which enforces this. Builds on top of #999.