cptbox: move logic from rule adding to constructor #999
Conversation
|
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #999 +/- ##
===========================================
- Coverage 81.12% 53.15% -27.97%
===========================================
Files 140 140
Lines 4753 4763 +10
===========================================
- Hits 3856 2532 -1324
- Misses 897 2231 +1334
Continue to review full report at Codecov.
|
|
ok to test |
Riolku
force-pushed
the
change-filesystem-policies
branch
3 times, most recently
from
a37cbc6
to
6fbb084
Compare
|
This is marginally beneficial to landlock, since it checks the paths before they are even added to the jail. It doesn't end up mattering as of now because we construct the jail anyway, but it's probably better for the long term. |
Riolku
force-pushed
the
change-filesystem-policies
branch
from
6fbb084
to
854557e
Compare
Basically, instead of checking that rules are correctly written when they are compiled into the jail, we should just check at construction time.
Riolku
force-pushed
the
change-filesystem-policies
branch
from
854557e
to
e0c292f
Compare
|
I'm confused: did you mean to merge the PR that depended on this, #1010? If so, I'll just close this (or you can). |
|
I'm just going to close this. The commit has been merged anyways. |
Basically, instead of checking that rules are correctly written when they are compiled into the jail, we should just check at construction time.