Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small bug with problem attempt icon #2104

Merged
merged 1 commit into from
Jan 8, 2023
Merged

Conversation

int-y1
Copy link
Contributor

@int-y1 int-y1 commented Jan 4, 2023

This ensures that 100/100 WA shows up as a problem attempt.

*_attempted_ids are used in these 3 places:

  • /problems/ to display orange icon in table column
  • /problems/?order=solved for solve order
  • /problem/aplusb to display orange icon in title

In all of these, a set works well enough, and a dict is unnecessary.

@codecov-commenter
Copy link

Codecov Report

Base: 46.67% // Head: 46.67% // No change to project coverage 👍

Coverage data is based on head (63acdc4) compared to base (5f2e28e).
Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2104   +/-   ##
=======================================
  Coverage   46.67%   46.67%           
=======================================
  Files         240      240           
  Lines       13263    13263           
=======================================
  Hits         6190     6190           
  Misses       7073     7073           
Impacted Files Coverage Δ
judge/utils/problems.py 26.86% <33.33%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

judge/utils/problems.py Outdated Show resolved Hide resolved
@Xyene Xyene merged commit 8bdf61b into DMOJ:master Jan 8, 2023
@int-y1 int-y1 deleted the attempt-icon branch January 8, 2023 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants