Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm install gives warnings about vulnerabilities #1813

Closed
Yu-Chieh-Henry-Yang opened this issue Aug 16, 2018 · 2 comments
Closed

npm install gives warnings about vulnerabilities #1813

Yu-Chieh-Henry-Yang opened this issue Aug 16, 2018 · 2 comments

Comments

@Yu-Chieh-Henry-Yang
Copy link

Yu-Chieh-Henry-Yang commented Aug 16, 2018

Expected behaviour:
npm install should install all packages without vulnerabilities

Actual behaviour:
Following installation guide, part of npm install output shows:

Testing binary
Binary is fine
added 1178 packages from 1021 contributors and audited 6453 packages in 16.457s
found 228 vulnerabilities (195 low, 21 moderate, 11 high, 1 critical)
run npm audit fix to fix them, or npm audit for details

Note:
running npm audit fix shows this:

  • eslint-plugin-import@2.13.0
  • node-sass@4.9.2
    added 4 packages from 6 contributors, removed 31 packages and updated 34 packages in 9.32s
    fixed 183 of 228 vulnerabilities in 6453 scanned packages
    4 package updates for 45 vulns involved breaking changes
    (use npm audit fix --force to install breaking changes; or refer to npm audit for steps to fix these manually)

which means there is still vulnerabilities

Steps to reproduce:
Following installation guide, up to the npm install step

@Yu-Chieh-Henry-Yang Yu-Chieh-Henry-Yang changed the title npm install has vulnerabilities that needs to be addressed npm install warns about vulnerabilities Aug 16, 2018
@Yu-Chieh-Henry-Yang Yu-Chieh-Henry-Yang changed the title npm install warns about vulnerabilities npm install gives warnings about vulnerabilities Aug 16, 2018
@magdalenadrafiova
Copy link

@briri and @xsrust is still still relevant?

@briri
Copy link
Contributor

briri commented Jul 6, 2020

yes. the upgrade should address most of these

@briri briri closed this as completed Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants