Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a yellow outline to indicate where a user has tabbed #2170

Closed
magdalenadrafiova opened this issue Jul 9, 2019 · 8 comments
Closed

Use a yellow outline to indicate where a user has tabbed #2170

magdalenadrafiova opened this issue Jul 9, 2019 · 8 comments
Assignees

Comments

@magdalenadrafiova
Copy link

magdalenadrafiova commented Jul 9, 2019

From the accessibility testing another issue is that we should implement a yellow outline to indicate where a user has tabbed rather than a dotted outline to make navigation by keyboard only easier and consider adding a skip to main content link

@magdalenadrafiova magdalenadrafiova added this to Accessibility in Roadmap backlog Jul 9, 2019
@magdalenadrafiova magdalenadrafiova removed this from Accessibility in Roadmap backlog Jul 16, 2019
@magdalenadrafiova magdalenadrafiova added this to Pending in Current sprint Jul 16, 2019
@johnpinto1 johnpinto1 moved this from Pending to In progress in Current sprint Aug 5, 2019
@johnpinto1 johnpinto1 self-assigned this Aug 5, 2019
@johnpinto1
Copy link
Contributor

Attached screen shot of issue on IE
Selection_067
Selection_066
Selection_065

@johnpinto1
Copy link
Contributor

@magdalenadrafiova @dsisu @sjDCC @xsrust @briri
Please give feedback that this is what we want or not (cf., screen shots of Roadmap on IE11)
I can implement this change with a simple CSS changes:

  • add yellow to _colours.scss

$color-yellow: #ff0; // Focus colors $color-focus: $color-yellow;

  • add to _accessibility.scss
    a, button, input, .form-control { &:focus, &:hover, &:active { outline-style: solid !important; outline-color: $color-focus !important; outline-width: 4px !important; } }

Yellow109
Yellow108
Yellow107
Selection_106
Yellow105
Yellow104
Yellow103
Yellow102
Yellow101
Yellow100
Yellow099
Yellow098
Yellow097
Yellow096
Yellow095
Yellow094
Yellow093
Yellow092
Yellow091
Yellow090

@johnpinto1
Copy link
Contributor

johnpinto1 commented Aug 12, 2019

@magdalenadrafiova @dsisu @sjDCC @xsrust @briri @killiandunne2 After this morning's discussion changed highlighting to Darkest Alice Blue (which we use for links).
Selection_125
Here are some screen shots of results:
Test Bullets 2 - Write plan - Chromium_124
Test Bullets 2 - Write plan - Chromium_123
Test Bullets 2 - Write plan - Chromium_121
Test Bullets 2 - Write plan - Chromium_120
Test Bullets 2 - Share - Chromium_119
Test Bullets 2 - Share - Chromium_118

@johnpinto1 johnpinto1 moved this from In progress to Review in Current sprint Aug 12, 2019
@sjDCC
Copy link
Contributor

sjDCC commented Aug 12, 2019

Looks good. Thanks @johnpinto1

johnpinto1 added a commit that referenced this issue Aug 13, 2019
…r controls when they receive keyboard focus.

(WCAG 2.0, Additional Techniques (Advisory) for Sucess Criterion 2.4.3, https://www.w3.org/TR/UNDERSTANDING-WCAG20/navigation-mechanisms-focus-order.html)

Changes:

- Added an outline to links, buttons, select menus and other bootstrap form controls.
- The outline colour was set to #107896 (Darkest Alice Blue) which is the default colour for links.
- The default outline with set to 2px, except for buttons where it is set to 3px
to improve visiblity.

Fix for #2170.
@johnpinto1
Copy link
Contributor

@xsrust has pointed out an issue with highlighting links in a table. He pointed out that it would be better to highlight the table cell in such cases. So will try to see if I can sort this out.

@johnpinto1 johnpinto1 moved this from Review to In progress in Current sprint Sep 6, 2019
johnpinto1 added a commit that referenced this issue Sep 11, 2019
Note we use the css :focus-within psuedo class that is not supported in either
IE or Edge
https://developer.mozilla.org/en-US/docs/Web/CSS/:focus-within

Fix #2170
@johnpinto1
Copy link
Contributor

Following @xsrust 's suggesttion I have added an outline to table cells when in focus. Attached are sone screen shots. We might want to discuss this change.
Ex1_tab_ouline
Ex2_tab_outline

@johnpinto1 johnpinto1 moved this from In progress to Review in Current sprint Sep 11, 2019
@sjDCC
Copy link
Contributor

sjDCC commented Sep 28, 2019

Looks good. Closing out

@sjDCC sjDCC closed this as completed Sep 28, 2019
@sjDCC sjDCC moved this from Review to UAT in Current sprint Sep 28, 2019
@magdalenadrafiova
Copy link
Author

Looks good

@briri briri removed this from UAT in Current sprint Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants