Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XSS issues #2712

Closed
briri opened this issue Oct 15, 2020 · 1 comment
Closed

Fix XSS issues #2712

briri opened this issue Oct 15, 2020 · 1 comment
Assignees

Comments

@briri
Copy link
Contributor

briri commented Oct 15, 2020

Brakeman detected a few cross site scripting vulnerabilities:

Confidence: Weak
Category: Cross-Site Scripting
Check: CrossSiteScripting
Message: Unescaped model attribute
Code: IdentifierPresenter.new(:identifiable => User.find(params[:id])).id_for_display(:id => identifier, :with_scheme_name => true)
File: app/views/org_admin/users/edit.html.erb
Line: 63

Confidence: Weak
Category: Cross-Site Scripting
Check: CrossSiteScripting
Message: Unescaped model attribute
Code: IdentifierPresenter.new(:identifiable => Org.find(params[:id])).id_for_display(:id => IdentifierPresenter.new(:identifiable => Org.find(params[:id])).id_for_scheme(:scheme => scheme))
File: app/views/orgs/_external_identifiers.html.erb
Line: 20

Confidence: Weak
Category: Cross-Site Scripting
Check: CrossSiteScripting
Message: Unescaped model attribute
Code: IdentifierPresenter.new(:identifiable => Org.find(params[:id])).id_for_display(:id => IdentifierPresenter.new(:identifiable => Org.find(params[:id])).id_for_scheme(:scheme => scheme))
File: app/views/orgs/_external_identifiers.html.erb
Line: 65

Confidence: Weak
Category: Cross-Site Scripting
Check: CrossSiteScripting
Message: Unescaped model attribute
Code: IdentifierPresenter.new(:identifiable => User.find(params[:id])).id_for_display(:id => identifier, :with_scheme_name => true)
File: app/views/super_admin/users/edit.html.erb
Line: 73

For possible solutions see: https://brakemanscanner.org/docs/warning_types/cross_site_scripting/

@mariapraetzellis
Copy link

@martaribeiro please check on this once you're done with the work on the scripting vulnerabilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants