Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create readme #2

Merged
merged 2 commits into from
May 18, 2016
Merged

Create readme #2

merged 2 commits into from
May 18, 2016

Conversation

briri
Copy link
Contributor

@briri briri commented May 18, 2016

Added an initial README file

@briri briri merged commit f204763 into DMPRoadmap:development May 18, 2016
briri added a commit that referenced this pull request May 18, 2016
* Added the initial README file

* corrected markup in the README
@marisastrong
Copy link
Member

I see that we are testing here, but we should ensure that merges have helpful messages attached to them. For example merge into . Can you add a message to these merges?

Marisa

From: Brian Riley <notifications@github.commailto:notifications@github.com>
Reply-To: DMPRoadmap/roadmap <reply@reply.github.commailto:reply@reply.github.com>
Date: Wednesday, May 18, 2016 at 2:58 PM
To: DMPRoadmap/roadmap <roadmap@noreply.github.commailto:roadmap@noreply.github.com>
Subject: Re: [DMPRoadmap/roadmap] Create readme (#2)

Merged #2#2.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHubhttps://github.com//pull/2#event-665051989

@briri
Copy link
Contributor Author

briri commented May 19, 2016

Agreed.

The message was in part due to 'squashing' the pull request into one commit. Github puts a link to the original commit messages, #2 and #3, in this case. It will be good practice to explain what is being merged to which branch and to re-summarize the changes

briri added a commit that referenced this pull request Aug 16, 2016
Rails 4.2 + initial API and I18n work
@briri briri mentioned this pull request Oct 17, 2016
briri pushed a commit that referenced this pull request Jan 27, 2017
Merged with DMPRoadmap/roadmap:master
@briri briri deleted the create-readme branch March 21, 2017 18:07
briri added a commit that referenced this pull request Jun 12, 2020
# This is the 1st commit message:

js assets linter config

fixed up webpacker so that its using standard babel transpiler and added eslint back in ... then fixed some linter issues

tweaks to config to use default webpacker uglifier/minifier

fixed up karma setup

updated github workflows to use yarn correctly

removed debug from js test

pegging us at bootstrap 3.x

fixes for tinymce

finished up tinymce changes

dumped old expandCollapseAll in favor of accordion. they were duplicates

tweak to github worfklow

duplicate require

Update mysql.yml

Update mysql.yml

Update mysql.yml

updated binstub copy of bundle

commented out failing test for JSON serialization

removed debug from mysql github workflow

js assets linter config

fixed up webpacker so that its using standard babel transpiler and added eslint back in ... then fixed some linter issues

# This is the commit message #2:

tweaks to config to use default webpacker uglifier/minifier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants