Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertion: 6.4.32 fails on 204, expects 200 #62

Closed
PhillipWatts1012 opened this issue Jan 3, 2018 · 2 comments · Fixed by #64
Closed

Assertion: 6.4.32 fails on 204, expects 200 #62

PhillipWatts1012 opened this issue Jan 3, 2018 · 2 comments · Fixed by #64
Assignees

Comments

@PhillipWatts1012
Copy link

https://github.com/DMTF/spmf/blob/master/Specification.md
Data modification requests
Actions (POST)
HTTP Status Code 200 indicates the Action request was successfully processed, with the JSON message body as described in Error Responses and providing a message indicating success or any additional relevant messages.
HTTP Status Code 204 indicates the Action is successful and is returned without a message body.

Therefore if no data, 204 should pass.

@billdodd billdodd self-assigned this Jan 3, 2018
@billdodd
Copy link
Contributor

billdodd commented Jan 3, 2018

Yes, looks like 204 should be fine.

Seems like in most cases, any time a 200 response is OK, a 204 would also be OK. It wouldn't be OK of course in cases where a response is required.

Thinking that the response_status_check() function in the tool should be modified to allow both 200 and 204 in the case where an explicit response code is not specified.

@PhillipWatts1012
Copy link
Author

PhillipWatts1012 commented Jan 3, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants