Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cfgfile option #67

Merged
merged 1 commit into from Jul 11, 2019
Merged

Add Cfgfile option #67

merged 1 commit into from Jul 11, 2019

Conversation

hustlzp1981
Copy link
Contributor

User and password can be read from cfgfile every time
so that the password will not be appear in command line.

Signed-off-by: zhipengl zhipengs.liu@intel.com

@hustlzp1981
Add Cfgfile option
e0bd7ba 
User and password can be read from cfgfile every time
so that the password will not be appear in command line.

Signed-off-by: zhipengl <zhipengs.liu@intel.com>
@hustlzp1981
Copy link
Contributor Author

Could you help review my patch.
If we use the –p option when invoking redfishtool then while that command is active and someone does a process listing then they can see the –p on the process listing. This is a security issue because a non-root user can learn the BMC password for any host by just doing a process listing on the active controller.

@mraineri
Copy link
Contributor

Approved 7/11

@mraineri mraineri merged commit 95996b0 into DMTF:master Jul 11, 2019
@hustlzp1981
Copy link
Contributor Author

Thanks!
BTW, do you have plan when we will release next version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hustlzp1981 @mraineri