Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Friendly URL logic #326

Closed
johnhenley opened this issue Jun 16, 2023 · 0 comments · Fixed by #327
Closed

Inconsistent Friendly URL logic #326

johnhenley opened this issue Jun 16, 2023 · 0 comments · Fixed by #327
Milestone

Comments

@johnhenley
Copy link
Collaborator

Describe the bug

Several sections of the module check whether the friendly url feature is installed when creating URLs. The check should also include determining in the feature is enabled, since the rewriter can be installed yet disabled. In that case, some code (such as email notifications) still executes as if the feature is enabled. To truly disable at, the rewriter needs to be uninstalled.

Software Versions

  • DNN: 09.11.01
  • Module: 07.00.10

To Reproduce

Steps to reproduce the behavior:

  1. In module settings, install rewriter but do not enable it
  2. Look at URL in email notifications. It is generated as friendly rather than old style.

Expected behavior

Code should look at enabled rather than--or in addition to--installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant