Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Correct behavior when Friendly URLs are disabled but still installed #327

Merged
merged 4 commits into from
Jun 22, 2023

Conversation

johnhenley
Copy link
Collaborator

@johnhenley johnhenley commented Jun 16, 2023

Description of PR...

Correct behavior when Friendly URLs are disabled but still installed

Changes made

  • Check module settings when using friendly URLs in addition to just seeing if rewriter is installed

PR Template Checklist

  • Fixes Bug
  • Feature solution
  • Other

Please mark which issue is solved

Close #326

@johnhenley johnhenley added the bug Something isn't working label Jun 16, 2023
@johnhenley johnhenley added this to the 07.00.11 milestone Jun 16, 2023
Copy link
Member

@WillStrohl WillStrohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@WillStrohl WillStrohl merged commit d1b18a7 into DNNCommunity:dev Jun 22, 2023
1 check passed
@johnhenley johnhenley deleted the issues/326 branch June 23, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent Friendly URL logic
2 participants