Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce standalone Forums Viewer module #209

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

johnhenley
Copy link
Collaborator

@johnhenley johnhenley commented Jan 18, 2023

Description of PR...

Older versions of Active Forums had the ability to show a forum group or forum on a different page than the one on which the Forums module was installed. This pull request reintroduces and packages that feature.

Changes made

  • Review previous code already in repo
  • Correct options/settings module loading logic
  • Build script/packaging to add module definition

PR Template Checklist

  • Fixes Bug
  • Feature solution
  • Other

Please mark which issue is solved

Close #206

@johnhenley johnhenley self-assigned this Jan 18, 2023
@johnhenley
Copy link
Collaborator Author

@WillStrohl I didn't create this as a separate version since their are no SQL files to conflict. However, there is an update the .dnn manifest, so let me know if you want a separate version for this one...

@johnhenley johnhenley added this to the 07.00.03 milestone Jan 18, 2023
Copy link
Member

@WillStrohl WillStrohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, pending testing. The scope of this update almost merits it being in a 7.1 or higher.

@WillStrohl WillStrohl merged commit e3960e9 into DNNCommunity:dev Jan 23, 2023
@johnhenley johnhenley deleted the issues/206 branch February 22, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ForumViewer
2 participants