Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Additional 08.00.00 Forums rebranding updates #394

Merged
merged 2 commits into from
Aug 14, 2023
Merged

TASK: Additional 08.00.00 Forums rebranding updates #394

merged 2 commits into from
Aug 14, 2023

Conversation

johnhenley
Copy link
Collaborator

@johnhenley johnhenley commented Jul 28, 2023 •
edited
Loading

Description of PR...

Additional 08.00.00 Forums rebranding updates

Changes made

  • remove extensionpackage rebranding package name change logic
  • update assembly to 08.00.00
  • update build targets to exclude GhostDoc.xml
  • update build targets to package ActiveForumsViewer as ForumsViewer
  • add cleanup file for 08.00.00 to remove ActiveForumsViewer manifest (now ForumsViewer)
  • update .gitignore for /BuildScripts/ICSharpCode.SharpZipLib.dll and /BuildScripts/MSBuild.Community.Tasks.dll

How did you test these updates?

Installed module as upgrade to existing 07.00.12

image
image

PR Template Checklist

  • Fixes Bug
  • [] Feature solution
  • Other
  • Requires documentation updates
  • I've updated the documentation already

Please mark which issue is solved

Associated with #280

@johnhenley
additional rebranding updates
99e61b9 
remove extensionpackage rebranding package name change logic
update assembly to 08.00.00
update build targets to exclude GhostDoc.xml
update build targets to package ActiveForumsViewer as ForumsViewer
add cleanup file for 08.00.00 to remove ActiveForumsViewer manifest (now ForumsViewer)
update .gitignore for /BuildScripts/ICSharpCode.SharpZipLib.dll and /BuildScripts/MSBuild.Community.Tasks.dll
@johnhenley johnhenley added the tasks General maintenance tasks that aren't typical development label Jul 28, 2023
@johnhenley johnhenley added this to the 08.00.00 milestone Jul 28, 2023
@johnhenley johnhenley self-assigned this Jul 28, 2023
@johnhenley johnhenley mentioned this pull request Aug 10, 2023
Closed
WillStrohl
WillStrohl approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@WillStrohl WillStrohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@WillStrohl WillStrohl merged commit 0758bc7 into DNNCommunity:dev Aug 14, 2023
1 check passed
@johnhenley
Copy link
Collaborator Author

Looks good!

You're killin' me. I just updated this branch to add the new logos from Timo :)
I'll do another PR.

@johnhenley johnhenley mentioned this pull request Oct 10, 2023
Closed
@johnhenley johnhenley mentioned this pull request Mar 14, 2024
Merged
5 tasks
@johnhenley johnhenley mentioned this pull request Apr 4, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillStrohl WillStrohl WillStrohl approved these changes

Assignees

@johnhenley johnhenley

Labels
tasks General maintenance tasks that aren't typical development
Projects
None yet
Milestone
08.00.00
Development

Successfully merging this pull request may close these issues.
3 participants
@johnhenley @WillStrohl @Timo-Breumelhof