FIX: subscriptions using anonymous user #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atform UserId; change it to AuthorId
…atform UserId; change it to AuthorId
…ttps://github.com/johnhenley/Dnn.CommunityForums into issues/533-quick-reply-not-using-authenticated-user
johnhenley
changed the title
johnhenley
deleted the
issues/533-quick-reply-not-using-authenticated-user
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR...
When adding the 'ban user' feature (#257), added a UserId property to ForumBase in order to pass the author/user to be banned; this conflicted with a UserId global property and caused issues related to subscriptions, such as Quick Reply sending email notifications using 'anonymous' rather than the correct user id.
Changes made
How did you test these updates?
tested quick reply before and after and monitored email notifications
PR Template Checklist
Please mark which issue is solved
Close #533