Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Modernizes Permissions-related code to use DAL2 #719

Merged
merged 39 commits into from
Apr 3, 2024
Merged

TASK: Modernizes Permissions-related code to use DAL2 #719

merged 39 commits into from
Apr 3, 2024

Conversation

johnhenley
Copy link
Collaborator

Description of PR...

Changes made

  • Uses new RepositoryControllerBase
  • Modernizes PermissionsInfo entity
  • Modernizes PermissionsController
  • Moves (most) SQL and stored procedures related to Permissions to DAL2
  • Various code improvements

How did you test these updates?

local install

PR Template Checklist

  • Fixes Bug
  • Feature solution
  • Other
  • Requires documentation updates
  • I've updated the documentation already

Please mark which issue is solved

Associated with #266

@johnhenley
DAL2: PermissionInfo & PermissionController
0049be9
@johnhenley
Merge branch 'dev81/3-dal2/1-controllerbase' into dev81/3-dal2/2-Perm…
d0c58d9 
…issionInfo
@johnhenley
DAL2: PermissionInfo & PermissionController
0f1df81
@johnhenley
RepositoryControllerBase
22e61e0
@johnhenley
apply controllerbase/repositorycontrollerbase
ed84026
@johnhenley
respositoryControllerBase for Permissions
7bad11b
@johnhenley
RepositoryControllerBase
570167c
@johnhenley
modernize FilterController/FilterInfo & LIkeInfo/LikeController
52f6820
@johnhenley
modernize PermissionInfo
013a8e0
@johnhenley
Merge branch 'dev81/3-dal2/3-LikeInfo' into dev81/3-dal2/4-Permission…
30d8332 
…Info
@johnhenley
Merge branch 'dev81/3-dal2/3-LikeInfo' into dev81/3-dal2/4-Permission…
8bdabe2 
…Info
@johnhenley
Add Scoped Get method to RepositoryControllerBase
7dadb8c
@johnhenley
Add Scoped Get method to RepositoryControllerBase
157df53
@johnhenley
Mark deprecated items
95c72f5
@johnhenley
Add Scoped Get method to RepositoryControllerBase
4c7c54f
@johnhenley
Fix GetRoleIds()
3b065f2
@johnhenley
Merge branch 'dev81/3-dal2/3-LikeInfo' into dev81/3-dal2/4-Permission…
406a5dd 
…Info
@johnhenley
permissions
90bcdbc
@johnhenley
resync dev
5ef2eb0
@johnhenley
Add nunit.Analyzers to migrate nunit3 to nunit4
3ff994a
@johnhenley
update NUnit 3.13.3 to 4.1.0
3b40e14 
update NUnit3TestAdapter 4.3.1 to 4.5.0
@johnhenley
update Moq 4.18.4 to 4.20.70
b4d699d
@johnhenley
update Microsoft.CodeCoverage 17.4.1 to 17.9.0
dda02da 
update Microsoft.NET.Test.Sdk  17.4.1 to 17.9.0
@johnhenley
add rudimentary unit tests
43fb528
@johnhenley
centralize duplicated code from security grids UI to permissions cont…
9e84670 
…roller
@johnhenley
resync dev
e4f1d3d
@johnhenley
resync dev
b0890a5
@johnhenley
Don't move deprecated classes to deprecated folder; leave in existing…
d81875d 
… location
@johnhenley
Modernized FilterInfo
d8a7581
@johnhenley
resync dev
7ba7e0c
@johnhenley johnhenley added tasks General maintenance tasks that aren't typical development technical debt Issue that doesn't directly affect usability but will improve technical debt posture performance An update likely to improve site performance labels Mar 27, 2024
@johnhenley johnhenley added this to the 08.01.00 milestone Mar 27, 2024
@johnhenley johnhenley self-assigned this Mar 27, 2024
@johnhenley johnhenley merged commit cc4d480 into DNNCommunity:dev Apr 3, 2024
1 check passed
@johnhenley johnhenley deleted the dev81/3-dal2/04-PermissionInfo branch April 3, 2024 14:11
@johnhenley johnhenley restored the dev81/3-dal2/04-PermissionInfo branch April 3, 2024 14:18
@johnhenley johnhenley deleted the dev81/3-dal2/04-PermissionInfo branch April 3, 2024 14:19
@johnhenley johnhenley linked an issue Apr 30, 2024 that may be closed by this pull request
Refactor/Modernize Entities and Controllers #266
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@johnhenley johnhenley

Labels
performance An update likely to improve site performance tasks General maintenance tasks that aren't typical development technical debt Issue that doesn't directly affect usability but will improve technical debt posture
Projects
None yet
Milestone
08.01.00
Development

Successfully merging this pull request may close these issues.

Refactor/Modernize Entities and Controllers
1 participant
@johnhenley