Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize topic properties to use DAL2 #746

Merged
merged 12 commits into from
Apr 11, 2024
Merged

Modernize topic properties to use DAL2 #746

merged 12 commits into from
Apr 11, 2024

Conversation

johnhenley
Copy link
Collaborator

Description of PR...

Continued modernization of Community Forums

Changes made

  • Modernizes entities
  • Modernizes controllers
  • Moves (most) SQL and stored procedures related to DAL2
  • Various code improvements

How did you test these updates?

local install

PR Template Checklist

  • Fixes Bug
  • Feature solution
  • Other
  • Requires documentation updates
  • I've updated the documentation already

Please mark which issue is solved

Associated with #266

@johnhenley johnhenley added tasks General maintenance tasks that aren't typical development technical debt Issue that doesn't directly affect usability but will improve technical debt posture labels Apr 10, 2024
@johnhenley johnhenley added this to the 08.01.00 milestone Apr 10, 2024
@johnhenley johnhenley self-assigned this Apr 10, 2024
WillStrohl
WillStrohl approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@WillStrohl WillStrohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@WillStrohl
Copy link
Member

@johnhenley There are conflicts. 🫣

@johnhenley
Copy link
Collaborator Author

@johnhenley There are conflicts. 🫣

Naturally. Conflicts resolved.

WillStrohl
WillStrohl approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@WillStrohl WillStrohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@WillStrohl WillStrohl merged commit 3630e91 into DNNCommunity:dev Apr 11, 2024
1 check passed
@johnhenley johnhenley deleted the dev81/4-webapi/2-topicproperties branch April 11, 2024 15:39
@johnhenley johnhenley linked an issue Apr 30, 2024 that may be closed by this pull request
Refactor/Modernize Entities and Controllers #266
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillStrohl WillStrohl WillStrohl approved these changes

Assignees

@johnhenley johnhenley

Labels
tasks General maintenance tasks that aren't typical development technical debt Issue that doesn't directly affect usability but will improve technical debt posture
Projects
None yet
Milestone
08.01.00
Development

Successfully merging this pull request may close these issues.

Refactor/Modernize Entities and Controllers
2 participants
@johnhenley @WillStrohl