Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cloudflare and Google #905

Merged
merged 12 commits into from
Jul 3, 2024
Merged

Update Cloudflare and Google #905

merged 12 commits into from
Jul 3, 2024

Conversation

demarcush
Copy link
Contributor

No description provided.

@jedisct1
Copy link
Member

Cloudflare certificates change all the time, and this is also inconsistent depending on the client location. Unfortunately, we can't include hashes for them, this breaks too frequently.

@demarcush
Copy link
Contributor Author

demarcush commented May 14, 2024

And yet they're the most likely target by hackers and state actors. What a shame!

@demarcush
Copy link
Contributor Author

demarcush commented May 19, 2024

Certificates are different for dns.cloudflare.com and the ones with IP SANs. Do both of them change all the time?
Maybe we can salvage one group by providing the hash.
@jedisct1

@jedisct1
Copy link
Member

jedisct1 commented Jul 3, 2024

We should keep sdns://AgcAAAAAAAAABzEuMC4wLjEAEmRucy5jbG91ZGZsYXJlLmNvbQovZG5zLXF1ZXJ5.
This is a special entry for dnscrypt-proxy, and there's some history behind it, that goes back to before Cloudflare DNS was publicly announced.

@jedisct1 jedisct1 merged commit 9a92b8e into DNSCrypt:next Jul 3, 2024
2 checks passed
jedisct1 added a commit that referenced this pull request Jul 3, 2024
* 'next' of github.com:DNSCrypt/dnscrypt-resolvers:
  Update Cloudflare and Google (#905)
@demarcush demarcush deleted the cf-gg branch July 3, 2024 17:25
@jedisct1
Copy link
Member

jedisct1 commented Jul 7, 2024

@demarcush
Copy link
Contributor Author

Weirdly enough, I can't find the latest dnscrypt-proxy package for Debian stable (link). 2.0.45 (from 4 yrs ago!) is the latest version supported on Debian oldstable. Yet as this link suggests, default version was v3 for that.

So, user didn't bother to update the container or migrate to the native package by Debian.
And probably copied the example config file from the latest release of the time during initial configuration (which was meant for a v3 supporting release).

I'm not convinced even a v2 user of the software would have problems with the changes made to Cloudflare.

@jedisct1
Copy link
Member

jedisct1 commented Jul 8, 2024

Yeah, they had a Frankenstein configuration. IP addresses should indeed be fine even for v2 users.

@demarcush
Copy link
Contributor Author

But the problem wasn't the IP addrs used as hostnames. It was the fact that v2 didn't support multi stamps under one entry.

@jedisct1
Copy link
Member

jedisct1 commented Jul 8, 2024

Yes.

@DNSCrypt DNSCrypt locked and limited conversation to collaborators Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants