Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize Adguard and DNS.SB #913

Closed
wants to merge 2 commits into from
Closed

Conversation

demarcush
Copy link
Contributor

No description provided.

@jedisct1
Copy link
Member

jedisct1 commented Jul 2, 2024

The IP address is expected to be in the IP address field.

Not sure what applications will do if they only see an IP address in the host name field. Presumably try to resolve it using a resolver, which is going to fail.

@demarcush
Copy link
Contributor Author

Well, no. It just makes the stamp uselessly longer. Your library for parsing and using stamps correctly does this (as used in dnscrypt-proxy and dnslookup).

@jedisct1
Copy link
Member

jedisct1 commented Jul 2, 2024

If it works, this is by accident 😊 That behavior is not part of the specification.

@demarcush
Copy link
Contributor Author

demarcush commented Jul 2, 2024

It's the first time I'm seeing something works by not following the specs. 😄

You saw this when merging my other PRs, like for yandex, right? Why now mentioning it?
You remember they're not just IPs but FQDNs defined as Subject Alt Names?

@jedisct1
Copy link
Member

jedisct1 commented Jul 3, 2024

Because I didn't pay attention to this in your previous PRs :)

@demarcush
Copy link
Contributor Author

Well, and I thought "If https works with only the IP, put it as the host to evade DPI and censorship."

Seems win-win to me.

@demarcush demarcush closed this Jul 12, 2024
@demarcush demarcush deleted the adg-sb-fix branch July 12, 2024 10:48
@DNSCrypt DNSCrypt locked and limited conversation to collaborators Aug 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants