C++17 is the minimum required C++ level to compile ACE/TAO after this PR #2224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… default C++ version for Visual Studio to 2017
* ACE/ace/Global_Macros.h:
* ACE/bin/MakeProjectCreator/config/acedefaults.mpb:
* ACE/bin/MakeProjectCreator/config/vs2017nmake.mpb:
* ACE/bin/MakeProjectCreator/config/vs2019nmake.mpb:
* ACE/bin/MakeProjectCreator/config/vs2022nmake.mpb:
* TAO/tests/Oneway_Send_Timeouts/Server_Task.h:
* TAO/tests/Oneway_Send_Timeouts/main.cpp:
* ACE/bin/MakeProjectCreator/config/acedefaults.mpb:
* ACE/bin/MakeProjectCreator/config/vs2017nmake.mpb:
* ACE/bin/MakeProjectCreator/config/vs2019nmake.mpb:
* ACE/bin/MakeProjectCreator/config/vs2022nmake.mpb:
* ACE/include/makeinclude/platform_linux_clang.GNU:
* ACE/include/makeinclude/platform_macosx_common.GNU:
* .github/workflows/linux.yml:
* ACE/include/makeinclude/platform_linux_clang.GNU:
* ACE/include/makeinclude/platform_macosx_common.GNU:
* ACE/bin/MakeProjectCreator/config/acedefaults.mpb:
* ACE/bin/MakeProjectCreator/config/vs2017nmake.mpb:
* ACE/bin/MakeProjectCreator/config/vs2019nmake.mpb:
* ACE/bin/MakeProjectCreator/config/vs2022nmake.mpb:
* .github/workflows/cmake.yml:
* ACE/bin/MakeProjectCreator/config/acedefaults.mpb:
* ACE/include/makeinclude/platform_linux_clang.GNU:
* .github/workflows/linux.yml:
* .github/workflows/linux.yml:
* ACE/include/makeinclude/platform_linux_clang.GNU:
* ACE/NEWS:
* ACE/ace/checked_iterator.h:
iguessthislldo
requested changes
Apr 24, 2024
ACE/NEWS
Outdated
| @@ -1,6 +1,10 @@ | |||
| USER VISIBLE CHANGES BETWEEN ACE-7.1.4 and ACE-7.1.5 | |||
There was a problem hiding this comment.
Please make this a major release if you're requiring a newer C++ standard.
There was a problem hiding this comment.
I will make it a new minor, we are not deprecating specific compilers, just lifting the required C++ standard
There was a problem hiding this comment.
Stop resolving this. I still don't agree.
Co-authored-by: Fred Hornsey <fred@hornsey.us>
* ACE/include/makeinclude/platform_gcc_clang_common.GNU:
* ACE/NEWS:
* TAO/NEWS:
* ACE/NEWS:
…iler flags to suppress the stdext::checked_array_iterator deprecation warnings at this moment
* ACE/bin/MakeProjectCreator/config/vc_warnings.mpb:
|
Jobs are failing because of some github issue actions/runner-images#9733 |
* .github/workflows/cmake.yml:
* .github/workflows/linux.yml:
traversaro
added a commit
to robotology/ycm-cmake-modules
that referenced
this pull request
May 17, 2024
Fix #444, see DOCGroup/ACE_TAO#2224 for the upstream change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes changes to set the C++ compiler default for Visual Studio 2017/2019/2022 to C++17